fix: pick an escape placeholder that cannot collide with the destination - #284
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit bd76212
☁️ Nx Cloud last updated this comment at |
LadyBluenotes
force-pushed
the
fix-markdown-placeholder
branch
from
September 12, 2026 02:17
eeb127a to
b858159
Compare
commit: |
The Markdown destination rewrite hid backslash escapes behind a fixed U+E000 while path functions ran, then turned every U+E000 back into a backslash. A destination that already contained U+E000 came out with a backslash in its place. Choose the first private-use code point absent from the destination instead. Follow-up to a CodeRabbit finding on #275.
LadyBluenotes
force-pushed
the
fix-markdown-placeholder
branch
from
September 12, 2026 02:55
b858159 to
bd76212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to CodeRabbit's finding on #275. The Markdown destination rewrite hid backslash escapes behind a fixed U+E000 while path functions ran, then restored every U+E000 as a backslash, so a destination that already contained U+E000 (
docs/a\uE000b.md) was corrupted. The placeholder is now the first private-use code point that does not occur in the destination. Test added for a destination containing both U+E000 and an escaped paren.