chore: move AntlrGrammars project to .NET Standard, sdk-style#1105
Open
tlecomte wants to merge 4 commits into
Open
chore: move AntlrGrammars project to .NET Standard, sdk-style#1105tlecomte wants to merge 4 commits into
tlecomte wants to merge 4 commits into
Conversation
For a couple of years .NET projects can use `PackageReference` instead of `packages.config` to list dependencies. This has several immediate benefits. The main advantage is that it simplifies the project files and removes redundancy, since packages only have to be listed in one place, and transitive dependencies no longer need to be listed. Reference: https://learn.microsoft.com/en-us/nuget/consume-packages/migrate-packages-config-to-package-reference This is also a step towards migrating the project files to the newer "sdk-style" format.
chore: move from packages.config to PackageReference
This moves the `AntlrGrammars` project to .NET Standard, together with migrating the project file to the newer "sdk-style" format. The benefits are: - .NET Standard means that the dlls built for this project are cross-platform and are both compatible with .NET Framework 4.8, and with .NET Core. - the "sdk-style" format is simpler, as source files are automatically included based on their path. Also, several assembly properties are directly defined in the project file instead of requiring a separate AssemblyInfo.cs file. Tested by building locally on a fresh repo and starting TabularEditor.
Author
|
Dear @otykier here is another small contribution. If you like it, I'm happy with continuing such migrations progressively for the other projects. |
Collaborator
|
Hi @tlecomte - thanks a lot for this contribution. |
Author
|
Oh sorry about that @otykier. I'll try to find some time to look at the installer project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
AntlrGrammarsproject to .NET Standard, together with migrating the project file to the newer "sdk-style" format.The benefits are:
Tested by building locally on a fresh repo and starting TabularEditor.