Skip to content

Conversation

@TMo484
Copy link
Owner

@TMo484 TMo484 commented Aug 25, 2023

Changed _DEFAULT_VALUE from empty object (unsupported type by downstream methods) to None (one of the expected types)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis#523 🦕

Changed _DEFAULT_VALUE from empty object (unsupported type by downstream methods) to None (one of the expected types)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid default value for timeout in PollingFuture

2 participants