Skip to content

Commit 541352a

Browse files
committed
Removed use of deprecated rotate_extrude variant
1 parent c10bc22 commit 541352a

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

examples/Old/example007.scad

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ module cutout()
1818
module clip()
1919
{
2020
difference() {
21-
// NB! We have to use the deprecated module here since the "dorn"
22-
// layer contains an open polyline, which is not yet supported
23-
// by the import() module.
24-
rotate_extrude(file = "example007.dxf",
25-
layer="dorn", convexity = 3);
21+
rotate_extrude(convexity = 3, $fn = 0, $fa = 12, $fs = 2) {
22+
import(file = "example007.dxf", layer = "dorn");
23+
}
2624
for (r = [0, 90])
2725
rotate(r, [0, 0, 1])
2826
cutout();

examples/Old/example009.scad

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@ intersection() {
2020
linear_extrude(height = fanwidth, center = true, convexity = 10, twist = -fanrot)
2121
import(file = "example009.dxf", layer = "fan_top");
2222

23-
// NB! We have to use the deprecated module here since the "fan_side"
24-
// layer contains an open polyline, which is not yet supported
25-
// by the import() module.
26-
rotate_extrude(file = "example009.dxf", layer = "fan_side",
27-
origin = fan_side_center, convexity = 10);
23+
rotate_extrude(convexity = 10)
24+
import(file = "example009.dxf", layer = "fan_side", origin = [0, -40]);
2825
}
2926

3027
// Written by Clifford Wolf <clifford@clifford.at> and Marius

tests/regression/dumptest-examples/example007-expected.csg

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ group() {
33
multmatrix([[1, 0, 0, 0], [0, 1, 0, 0], [0, 0, 1, -10], [0, 0, 0, 1]]) {
44
group() {
55
difference() {
6-
rotate_extrude(file = "example007.dxf", layer = "dorn", origin = [0, 0], scale = 1, convexity = 3, $fn = 0, $fa = 12, $fs = 2);
6+
rotate_extrude(convexity = 3, $fn = 0, $fa = 12, $fs = 2) {
7+
import(file = "example007.dxf", layer = "dorn", origin = [0, 0], scale = 1, convexity = 1, $fn = 0, $fa = 12, $fs = 2);
8+
}
79
group() {
810
multmatrix([[1, 0, 0, 0], [0, 1, 0, 0], [0, 0, 1, 0], [0, 0, 0, 1]]) {
911
group() {

tests/regression/dumptest-examples/example009-expected.csg

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ group() {
1919
linear_extrude(height = 20, center = true, convexity = 10, twist = -57.5288, slices = 4, scale = [1, 1], $fn = 0, $fa = 12, $fs = 2) {
2020
import(file = "example009.dxf", layer = "fan_top", origin = [0, 0], scale = 1, convexity = 1, $fn = 0, $fa = 12, $fs = 2);
2121
}
22-
rotate_extrude(file = "example009.dxf", layer = "fan_side", origin = [0, -40], scale = 1, convexity = 10, $fn = 0, $fa = 12, $fs = 2);
22+
rotate_extrude(convexity = 10, $fn = 0, $fa = 12, $fs = 2) {
23+
import(file = "example009.dxf", layer = "fan_side", origin = [0, -40], scale = 1, convexity = 1, $fn = 0, $fa = 12, $fs = 2);
24+
}
2325
}
2426
}

0 commit comments

Comments
 (0)