Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 38.47% 38.53% +0.06%
==========================================
Files 88 99 +11
Lines 2773 4611 +1838
Branches 6 6
==========================================
+ Hits 1067 1777 +710
- Misses 1706 2834 +1128 |
mkucharz
requested changes
Oct 24, 2018
docs/docs/building-sockets/users.md
Outdated
| @@ -0,0 +1,109 @@ | |||
| # About users | |||
| In Syncano you have database classes. Users are just another type of database classes and you should think about users as a specific model of database. The easiest way to manage users is by using Syncano socket named user-auth. | |||
Member
There was a problem hiding this comment.
user-auth should be a link to npm
docs/docs/building-sockets/users.md
Outdated
| - update users data | ||
| - delete user | ||
|
|
||
| ### How to create User |
docs/docs/building-sockets/users.md
Outdated
|
|
||
| ## How to use user-auth socket | ||
|
|
||
| ### Register User |
Member
There was a problem hiding this comment.
a User here and in other places
docs/docs/building-sockets/users.md
Outdated
| @@ -0,0 +1,109 @@ | |||
| # About users | |||
Member
There was a problem hiding this comment.
lets be consistent, we are writing user with capital letter bellow
Member
|
Missing labels. |
add a word before user
mkucharz
approved these changes
Oct 25, 2018
Member
|
@jakubkornafel you forgot to delete a branch here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.