Move babel to dev deps in lib-js-test and test-tools#205
Merged
Conversation
Member
Author
|
@mkucharz looks like we need to update babel to v7 in all packages to make this pass. I guess we can postpone this. What do you think? |
Member
Author
|
Hmm, for now I will downgrade back to babel 6 and move it to dev deps. It was in prod deps which probably caused error in 21st. 2 instances of babel, v6 and v7 detected in node modules might be the cause of that error: |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 34.66% 34.66%
=======================================
Files 119 119
Lines 4705 4705
=======================================
Hits 1631 1631
Misses 3074 3074 |
mkucharz
approved these changes
Apr 9, 2018
Idered
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use babel 7Move babel to dev deps