Fixed the Hosting BrowserRouter option flag to be using boolean values. Added Hosting config tests#140
Merged
adamwardecki merged 5 commits intomasterfrom Feb 12, 2018
Merged
Conversation
Contributor
adamwardecki
commented
Feb 12, 2018
adamwardecki
commented
- Changed the BrowserRouter flag in config to be kebab cased
- It wasn't possible to turn the BrowserRouter option off with the flags. Fixed it by changing to boolean values. This is a breaking change.
- Added a stdout of the current hosting config after setting it up (previously it just printed 'Configuration successfully updated!' without explicitly showing what changed).
added 5 commits
February 8, 2018 13:44
…alse in hosting config
…nake cased. BREAKING CHANGE
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 37.46% 28.79% -8.68%
==========================================
Files 118 102 -16
Lines 5272 2855 -2417
==========================================
- Hits 1975 822 -1153
+ Misses 3297 2033 -1264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.