docs(): socket update to 0.8+ recipe#135
Merged
maciejkorsan merged 2 commits intomasterfrom Feb 13, 2018
Merged
Conversation
mkucharz
requested changes
Feb 9, 2018
| yarn --production | ||
|
|
||
| ``` | ||
|
|
docs/cookbook/web/basics/update.md
Outdated
| #!/usr/bin/env sh | ||
|
|
||
| mkdir -p .dist | ||
| babel src --out-dir .dist/src --copy-files |
Member
There was a problem hiding this comment.
here we should have npx I think
docs/cookbook/web/basics/update.md
Outdated
| mkdir -p .dist | ||
| cp package.json .dist | ||
| cd .dist | ||
| yarn --production |
Member
There was a problem hiding this comment.
maybe we should use npm instead yarn?
Member
Author
There was a problem hiding this comment.
it doesn't work if i change it to npm
Member
There was a problem hiding this comment.
@maciejkorsan you need npm install (which is default in yarn)
docs/cookbook/web/basics/update.md
Outdated
|
|
||
| ```js | ||
| "scripts": { | ||
| "build": "yarn && yarn run build:src && yarn run build:env", |
Member
There was a problem hiding this comment.
yarn is not dependency anymore so maybe we should use npm?
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
- Coverage 37.46% 34.9% -2.56%
=========================================
Files 118 118
Lines 5272 4595 -677
=========================================
- Hits 1975 1604 -371
+ Misses 3297 2991 -306 |
Member
Author
|
@mkucharz changes applied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.