Skip to content

Conversation

@adamwardecki
Copy link
Contributor

@adamwardecki adamwardecki commented Feb 2, 2018

fixes #118

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   27.85%   27.85%           
=======================================
  Files         102      102           
  Lines        2807     2807           
=======================================
  Hits          782      782           
  Misses       2025     2025

Copy link
Member

@mkucharz mkucharz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkucharz mkucharz requested a review from maciejkorsan February 2, 2018 09:04
@adamwardecki adamwardecki merged commit 70ad5b8 into master Feb 2, 2018
@adamwardecki adamwardecki deleted the docs/limits branch February 2, 2018 09:06
@adamwardecki
Copy link
Contributor Author

@mkucharz Sorry didn't notice the additional review request from @maciejkorsan and went ahead with the merge.

@mkucharz
Copy link
Member

mkucharz commented Feb 2, 2018

@adamwardecki no problem, let's just try to do it with all reviewers next time ;)

```
Applies for both Socket Endpoint Scripts and Event Handlers
```
The default execution time for Scripts is `30` seconds. It can be adjusted by adding a `timeout` property in the socket.yml. A valid range is `0 >` and `< 500` seconds. Integer and float values are allowed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamwardecki Max is 5 minutes. So 300s, not 500s.

| Description | Limit | Notes |
|--- |--- |--- |
|Data Object size | 32kB (serialized)||
|Data Object fields number|32 fields|16 of the Data Object fields can be indexed (you can use any type as index except TextField and FileField)|
Copy link
Member

@23doors 23doors Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamwardecki @mkucharz There is also ObjectField that cannot be indexed. Plus, in my opinion these names (TextField, IntegerField etc) are a little too python-like having Django feel all over. Guess that it may not be obvious that IntegerField is a field with type: integer. And this notion is not used in other places: https://github.com/Syncano/syncano-node/blob/master/docs/docs/building-sockets/data-classes.md#types-of-data-class-schema-fields so this is pretty inconsistent.

@adamwardecki
Copy link
Contributor Author

Continued in PR #124 as I was too quick to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add limits info to docs

4 participants