-
Notifications
You must be signed in to change notification settings - Fork 9
docs(common): add limit info to the documentation #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 27.85% 27.85%
=======================================
Files 102 102
Lines 2807 2807
=======================================
Hits 782 782
Misses 2025 2025 |
mkucharz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mkucharz Sorry didn't notice the additional review request from @maciejkorsan and went ahead with the merge. |
|
@adamwardecki no problem, let's just try to do it with all reviewers next time ;) |
| ``` | ||
| Applies for both Socket Endpoint Scripts and Event Handlers | ||
| ``` | ||
| The default execution time for Scripts is `30` seconds. It can be adjusted by adding a `timeout` property in the socket.yml. A valid range is `0 >` and `< 500` seconds. Integer and float values are allowed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamwardecki Max is 5 minutes. So 300s, not 500s.
| | Description | Limit | Notes | | ||
| |--- |--- |--- | | ||
| |Data Object size | 32kB (serialized)|| | ||
| |Data Object fields number|32 fields|16 of the Data Object fields can be indexed (you can use any type as index except TextField and FileField)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamwardecki @mkucharz There is also ObjectField that cannot be indexed. Plus, in my opinion these names (TextField, IntegerField etc) are a little too python-like having Django feel all over. Guess that it may not be obvious that IntegerField is a field with type: integer. And this notion is not used in other places: https://github.com/Syncano/syncano-node/blob/master/docs/docs/building-sockets/data-classes.md#types-of-data-class-schema-fields so this is pretty inconsistent.
|
Continued in PR #124 as I was too quick to close this one. |
fixes #118