fix(cli:attach) - fixes for issues #98 #99 #100 #101 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkucharz
requested changes
Feb 2, 2018
packages/cli/src/commands/attach.js
Outdated
| ]) | ||
|
|
||
| const instance = await this.session.createInstance(instanceName) | ||
| const instance = await createInstance(instanceName, this.session) |
Member
There was a problem hiding this comment.
in meantime, I changed a little bit this function to take session directly from the singleton, please check commands/init how to fix it
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 34.49% 34.59% +0.09%
==========================================
Files 118 118
Lines 4592 4550 -42
==========================================
- Hits 1584 1574 -10
+ Misses 3008 2976 -32 |
mkucharz
approved these changes
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for command attach (displaying correct error messages instead of exceptions), tests cleaning