Skip to content

Conversation

@maciejkorsan
Copy link
Member

No description provided.

@maciejkorsan maciejkorsan requested a review from mkucharz January 29, 2018 10:53
<pre><code class="lang-bash">npm install --global yarn
npm install -g syncano-cli</code></pre>
<pre><code class="lang-bash">
npm install -g @syncano/cli</code></pre>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper way now is to install CLI as a private dependency for your project - so it is not a global install.


* You have `node` v7.0.0+ installed and `yarn` at v0.17.10+ (as we use it for development)
* You are familiar with `npm`/`yarn`
* You have `node` v7.0.0+ installed (as we use it for development)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look into main package.json and engines requirements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're removing this section from cookbook, but I'll update corresponding file in docs

<span class="lite">⬢</span> $ npm install -g yarn<br />
<span class="lite">⬢</span> $ npm install -g syncano-cli<br />
<p>
<span class="lite">⬢</span> $ npm install -g @syncano/cli<br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a global anymore.

- [Cookbook](https://cookbook.syncano.io/#/)

- Canary version
- [v. 0.6](https://syncano.github.io/syncano-node-cli/#/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syncano-node-cli is an old CLI syncano-node is our current repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a link to old docs, not to the current repo

You can use a hot deployment feature which watches your socket's files and deploys it on change (you need to deploy your socket first in order to use this feature). If no socket name is provided it watches all of your sockets.

```sh
syncano-cli hot <socketname>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use local version of CLI we should use npx syncano-cli <command>. I want to find the way to have some alias no npx will not be necessary but so far it is (to run local executables).

```

If `syncano-server` is not listed there you can use `yarn` to install it (you have to be inside Socket folder):
If `syncano-server` is not listed there you can use `npm` to install it (you have to be inside Socket folder):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syncano-server is now @syncano/core.

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #111 into master will decrease coverage by 1.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #111     +/-   ##
=========================================
- Coverage   34.48%   33.38%   -1.1%     
=========================================
  Files         118       90     -28     
  Lines        4588     3795    -793     
=========================================
- Hits         1582     1267    -315     
+ Misses       3006     2528    -478

@mkucharz
Copy link
Member

mkucharz commented Feb 2, 2018

LGTM

@mkucharz mkucharz requested a review from adamwardecki February 2, 2018 09:09
### The Syncano CLI

Use the Syncano Command Line interface (CLI) to manage the whole build and deploy process. You can get it from npm with `npm install syncano-cli -g` command (it requires Node and Yarn to be installed). It's a powerful terminal tool, so you won't have to leave your working environment. The whole synchronization and deployment process happens automatically and seamlessly.
Use the Syncano Command Line interface (CLI) to manage the whole build and deploy process. You can get it from npm with `npm install @syncano/cli -g` command (it requires Node to be installed). It's a powerful terminal tool, so you won't have to leave your working environment. The whole synchronization and deployment process happens automatically and seamlessly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary -g flag

npx syncano-cli init
```

> There's shortcut for `syncano-cli` - you can simple type `s`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simple/simply


For more comfortable development process on Microsoft Windows, please install Windows Subsystem for Linux. You can find a detailed guide how to do this here: [docs.microsoft.com/en-us/windows/wsl/install-win10](https://docs.microsoft.com/en-us/windows/wsl/install-win10).

You will also need a working nodejs enviroment. Please follow this guide: [hackernoon.com/running-nodejs-on-linux-on-windows-88bd12993bae](https://hackernoon.com/running-nodejs-on-linux-on-windows-88bd12993bae). No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/enviroment/environment

It will be submitted to npm with `@canary` tag. From there we will merge it into `master` that will bump proper version of `CLI`.

#### Waiting for review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parts below about commiting and the release process are no longer valid

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamwardecki any suggestions on this? how does it look now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The whole section about commiting should be removed
  • we don't use commitizen, although commits should have a conventional commit style https://conventionalcommits.org/
  • we don't use semantic release. seems that lerna handles the release process (It's @mkucharz who configured the set up, so he'll be able to tell more about it)

I see this section is in two places docs/common and cookbook/common

@mkucharz
Copy link
Member

mkucharz commented Feb 8, 2018

@maciejkorsan I think that maybe we should try to close it soon ;)

@maciejkorsan
Copy link
Member Author

@mkucharz have a look

@mkucharz
Copy link
Member

mkucharz commented Feb 9, 2018

@maciejkorsan let's do it! :)

@maciejkorsan maciejkorsan merged commit b8d4214 into master Feb 9, 2018
@mkucharz mkucharz deleted the docs/canary branch February 15, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants