Skip to content

Async bulk message transport #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoryHogeveen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Async bulk message transport #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16ff15c
Start on async bulk message transport
JoryHogeveen Dec 24, 2024
f8d49fe
Merge branch 'master' into feature/async-bulk
JoryHogeveen Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion config/packages/messenger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,21 @@ framework:
retry_strategy:
max_retries: 3
multiplier: 2
async_bulk:
dsn: "doctrine://default?queue_name=async_bulk"
options:
use_notify: true
retry_strategy:
max_retries: 0
failed: 'doctrine://default?queue_name=failed'
sync: 'sync://'

routing:
Symfony\Component\Mailer\Messenger\SendEmailMessage: sync
Symfony\Component\Notifier\Message\ChatMessage: async
Symfony\Component\Notifier\Message\SmsMessage: async
SyncEngine\Messenger\Message\AutomationBatch: async
SyncEngine\Messenger\Message\AsyncExecuteMessage: async
SyncEngine\Messenger\Message\AsyncExecuteBulkMessage: async_bulk

# Route your messages to the transports
# 'SyncEngine\Message\YourMessage': async
6 changes: 3 additions & 3 deletions ...senger/Handler/AutomationBatchHandler.php → ...Messenger/Handler/ExecuteBatchHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Messenger\Attribute\AsMessageHandler;
use SyncEngine\Controller\DefaultController;
use SyncEngine\Messenger\Message\AutomationBatch;
use SyncEngine\Messenger\Message\AsyncExecuteMessage;
use SyncEngine\Model\AutomationModel;
use SyncEngine\Model\TraceModel;
use SyncEngine\Service\Execute;
use SyncEngine\Service\ExecuteContext;

#[AsMessageHandler]
class AutomationBatchHandler
class ExecuteBatchHandler
{
public function __construct(
// Load required to instantiate container.
private readonly DefaultController $controller,
private readonly Execute $executeService
) {}

public function __invoke( AutomationBatch $message ): void
public function __invoke( AsyncExecuteMessage $message ): void
{
$model = AutomationModel::get( $message->getAutomationId() );

Expand Down
7 changes: 7 additions & 0 deletions src/Messenger/Message/AsyncExecuteBulkMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

namespace SyncEngine\Messenger\Message;

class AsyncExecuteBulkMessage extends AsyncExecuteMessage
{
}
2 changes: 1 addition & 1 deletion src/Messenger/Message/AutomationBatch.php → ...Messenger/Message/AsyncExecuteMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* @internal
*/
class AutomationBatch
class AsyncExecuteMessage
{
public function __construct(
private int $automationId,
Expand Down
4 changes: 2 additions & 2 deletions src/Service/Execute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
use SyncEngine\EventDispatcher\Event\ExecuteEvent;
use SyncEngine\Exception\ExecuteException;
use SyncEngine\Exception\NoResultsException;
use SyncEngine\Messenger\Message\AutomationBatch;
use SyncEngine\Messenger\Message\AsyncExecuteMessage;
use SyncEngine\Model\AutomationModel;
use SyncEngine\Model\Enum\AutomationEventType;
use SyncEngine\Model\Enum\TraceStatus;
Expand Down Expand Up @@ -86,7 +86,7 @@ public function schedule( AutomationModel $automation, ExecuteContext $context )
$params = $context->getRequestParams();
$query = $context->getRequestQuery();

$this->messageBus->dispatch( new AutomationBatch( $automation->getId(), $traceId, $params, $query ), $stamps );
$this->messageBus->dispatch( new AsyncExecuteMessage( $automation->getId(), $traceId, $params, $query ), $stamps );
}

public function fetch( AutomationModel $automation, ExecuteContext $context, $data = null ): ExecuteData
Expand Down