Skip to content

Set Example project Deployment Target to same as SwiftJSON project #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set Example project Deployment Target to same as SwiftJSON project #1115

wants to merge 1 commit into from

Conversation

@Dahlgren
Copy link
Contributor

@Dahlgren Dahlgren commented Mar 15, 2022 •
edited
Loading

Example project failed to compile since SwiftyJSON for iOS requires 9.0 deployment target while Example project had 8.0.

Naveen-C-Ramachandrappa
Naveen-C-Ramachandrappa approved these changes Jul 18, 2024
View reviewed changes
Copy link

@Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the example project deployment target.

@ankushkushwaha
Copy link

ankushkushwaha commented Jan 1, 2025

Thanks for this change. Could you please resolve the conflicts with base branch?

@Dahlgren Dahlgren force-pushed the bugfix/example-project-deployment-target branch from 66a30a3 to a20edf1 Compare January 1, 2025 12:35
@Dahlgren
Copy link
Contributor Author

Dahlgren commented Jan 1, 2025

Rebased on current master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ankushkushwaha ankushkushwaha ankushkushwaha approved these changes

@luoxiu luoxiu luoxiu approved these changes

@Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa Naveen-C-Ramachandrappa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dahlgren @ankushkushwaha @luoxiu @Naveen-C-Ramachandrappa