Fix/branch #1326
Open
Fix/branch #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added batching to the upload_scalar_metrics function to split uploads into chunks of configurable size (default 3000). This improves reliability and performance when uploading large numbers of scalar metrics.
Introduced MetricDict TypedDict for clearer type hints and refactored batching logic for metric, scalar, and column uploads into trace_metrics. Now batching is handled centrally with per_request_len parameter, simplifying upload_scalar_metrics and upload_columns. Added assertions for project and experiment IDs and improved error handling for column uploads.
Zeyi-Lin
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对除文件以外的所有上传实现批次上传，减轻后端压力