Bug | Illegal RegExp in Safari in 3.0.0-beta.1 and beta.2#1444
Merged
Sub6Resources merged 2 commits intoSub6Resources:masterfrom Mar 11, 2025
Merged
Bug | Illegal RegExp in Safari in 3.0.0-beta.1 and beta.2#1444Sub6Resources merged 2 commits intoSub6Resources:masterfrom
Sub6Resources merged 2 commits intoSub6Resources:masterfrom
Conversation
Owner
|
Thanks for the contribution. Whitespace bugs are among the most common issues reports I receive, so let me write a few unit tests to verify that this RegExp change still handles all the edge cases correctly. If so, then we can merge this, otherwise I'll probably have to write a custom code to handle these whitespace replacements to support Safari |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
- Coverage 64.08% 64.07% -0.02%
==========================================
Files 39 39
Lines 3032 3031 -1
==========================================
- Hits 1943 1942 -1
Misses 1089 1089 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sub6Resources
approved these changes
Mar 11, 2025
This was referenced Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the upgrade from 3.0.0-alpha6 to beta2, there is an issue on old Safari versions. The Html widget renders as a grey area and and the console the error is:
FormatException: Illegal RegExp pattern (SyntaxError: Invalid regular expression: invalid group specifier name)
(?<=\n) *