Feature/thead safety#31
Merged
StringEpsilon merged 4 commits intoStringEpsilon:mainfrom Jan 17, 2022
sommmen:feature/TheadSafety
Merged
Feature/thead safety#31StringEpsilon merged 4 commits intoStringEpsilon:mainfrom sommmen:feature/TheadSafety
StringEpsilon merged 4 commits intoStringEpsilon:mainfrom
sommmen:feature/TheadSafety
Conversation
Contributor
Author
|
Can be mitigated by |
Owner
|
You've got conflicts in the PR. A clean rebase to |
Contributor
Author
|
weird - github saids there're no conflicts:
ill see if i can work things out - haven't done a rebase before but ill google. |
Owner
|
Ah, my default merge option is "Rebase". That seems to be unhappy about your merge commits in between the actual work. I can squash merge just fine. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added thread safety to lookup caches.
Got some race conditions.
I encountered it when MakeClass was called with EnableTypeLookup = true (default).
Also implemented locking for the other caches just to be safe although i doubt this'd be a problem there.
Please release ASAP since this is blocking for me :)
No tests because this is not testable - other tests ran fine.