This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Fix highlighting of periods in phpDocComment#40
Merged
StanAngeloff merged 1 commit intoStanAngeloff:masterfrom Jul 23, 2015
synthetiv:master
Merged
Fix highlighting of periods in phpDocComment#40StanAngeloff merged 1 commit intoStanAngeloff:masterfrom synthetiv:master
StanAngeloff merged 1 commit intoStanAngeloff:masterfrom
synthetiv:master
Conversation
`phpCommentTitle` was misspelled in a matchgrp as `phpCommmentTitle`; this caused the first period in any phpDocComment to be highlighted as Normal instead of phpCommentTitle
StanAngeloff
added a commit
that referenced
this pull request
Jul 23, 2015
Fix highlighting of periods in phpDocComment.
Owner
|
This is great! Thanks for tracking it down to the misspelt group. 🎓 |
Author
|
No problem, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there - I've been using this script for a while, but somehow only recently noticed that if I had a period anywhere in a DocBlock comment, it would be highlighted differently from the rest of the comment. I tracked this down to a misspelling of the name of the
phpCommentTitlehighlight group.before:
after:
phpCommentTitle is linked to phpComment by default, but I don't think this will change anything substantial for users who might have phpCommentTitle highlighted differently.