Merged
Conversation
* improve(tests) refactored to hostname/pid providers * improve(tests)
Voronenko
requested review from
TizianoPerrucci
and removed request for
TizianoPerrucci
* improve(tests)
craffit
requested changes
Jun 14, 2018
| @Override | ||
| public long getPid() { | ||
| String processName = java.lang.management.ManagementFactory.getRuntimeMXBean().getName(); | ||
| return Long.parseLong(processName.split("@")[0]); |
There was a problem hiding this comment.
I like to see some comment here why we split on the '@', or alternatively: this implementation is probably based on some StackOverflow post or example, I'd like to see a link to that as a way of documentation.
craffit
approved these changes
Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.