Skip to content

Commit ccf158b

Browse files
rhooperrhooper
committed
raise mp_raise_NotImplementedError
1 parent fdddb54 commit ccf158b

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

‎extmod/modbtree.c‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,7 @@ STATIC mp_obj_t btree_iternext(mp_obj_t self_in) {
246246
}
247247
}
248248

249-
#pragma GCC diagnostic ignored "-Wunused-parameter"
250249
STATIC mp_obj_t btree_subscr(mp_obj_t self_in, mp_obj_t index, mp_obj_t value) {
251-
//mp_obj_btree_t *self = MP_OBJ_TO_PTR(self_in);
252250
mp_obj_btree_t *self = mp_instance_cast_to_native_base(self_in, &btree_type);
253251
if (value == MP_OBJ_NULL) {
254252
// delete

‎shared-bindings/_pixelbuf/PixelBuf.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,11 +332,11 @@ STATIC mp_obj_t pixelbuf_pixelbuf_unary_op(mp_unary_op_t op, mp_obj_t self_in) {
332332

333333
//| .. method:: show()
334334
//|
335-
//| Does nothing unless subclassed.
335+
//| Must be implemented in subclasses.
336336
//|
337337

338338
STATIC mp_obj_t pixelbuf_pixelbuf_show(mp_obj_t self_in) {
339-
return mp_const_none;
339+
mp_raise_NotImplementedError(NULL);
340340
}
341341
STATIC MP_DEFINE_CONST_FUN_OBJ_1(pixelbuf_pixelbuf_show_obj, pixelbuf_pixelbuf_show);
342342

0 commit comments

Comments
 (0)