Skip to content

Commit cb63006

Browse files
committed
py/runtime: Optimise case of identity iterator so it doesn't alloc RAM.
1 parent 30b42dd commit cb63006

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

py/runtime.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1103,14 +1103,20 @@ void mp_store_attr(mp_obj_t base, qstr attr, mp_obj_t value) {
11031103

11041104
mp_obj_t mp_getiter(mp_obj_t o_in, mp_obj_iter_buf_t *iter_buf) {
11051105
assert(o_in);
1106+
mp_obj_type_t *type = mp_obj_get_type(o_in);
1107+
1108+
// Check for native getiter which is the identity. We handle this case explicitly
1109+
// so we don't unnecessarily allocate any RAM for the iter_buf, which won't be used.
1110+
if (type->getiter == mp_identity_getiter) {
1111+
return o_in;
1112+
}
11061113

11071114
// if caller did not provide a buffer then allocate one on the heap
11081115
if (iter_buf == NULL) {
11091116
iter_buf = m_new_obj(mp_obj_iter_buf_t);
11101117
}
11111118

11121119
// check for native getiter (corresponds to __iter__)
1113-
mp_obj_type_t *type = mp_obj_get_type(o_in);
11141120
if (type->getiter != NULL) {
11151121
mp_obj_t iter = type->getiter(o_in, iter_buf);
11161122
if (iter != MP_OBJ_NULL) {

0 commit comments

Comments
 (0)