Skip to content

Commit acaa30b

Browse files
pfalconpfalcon
committed
unix: Deprecate support for GNU Readline (MICROPY_USE_READLINE=2).
MicroPython own readline implementation is superior now by providing automatic indentation and completion (completion for GNU Readline was never implemented). MICROPY_USE_READLINE=2 also wasn't build for a long time and probably broken. If GNU Readline is still beneficial for some cases, it can be achieved with external wrappers like "rlwrap" (there will be the same level of functionality, as again, there never was deep integration, like completion support).
1 parent f469c76 commit acaa30b

2 files changed

Lines changed: 0 additions & 7 deletions

File tree

‎unix/Makefile‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ INC += -I../lib/mp-readline
8585
CFLAGS_MOD += -DMICROPY_USE_READLINE=1
8686
LIB_SRC_C_EXTRA += mp-readline/readline.c
8787
endif
88-
ifeq ($(MICROPY_USE_READLINE),2)
89-
CFLAGS_MOD += -DMICROPY_USE_READLINE=2
90-
LDFLAGS_MOD += -lreadline
91-
# the following is needed for BSD
92-
#LDFLAGS_MOD += -ltermcap
93-
endif
9488
ifeq ($(MICROPY_PY_TIME),1)
9589
CFLAGS_MOD += -DMICROPY_PY_TIME=1
9690
SRC_MOD += modtime.c

‎unix/mpconfigport.mk‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ MICROPY_FORCE_32BIT = 0
66
# This variable can take the following values:
77
# 0 - no readline, just simple input
88
# 1 - use MicroPython version of readline
9-
# 2 - use GNU readline (causes binary to be licensed under GPL)
109
MICROPY_USE_READLINE = 1
1110

1211
# Whether to enable FatFs VFS

0 commit comments

Comments
 (0)