Skip to content

Commit 4ff05ae

Browse files
dpgeorgedpgeorge
committed
esp32/machine_uart: Remove UART event queue object.
This event queue has UART events posted to it and they need to be drained for it to operate without error. The queue is not used by the uPy UART class so it should be removed to prevent the IDF emitting errors. Fixes adafruit#3704.
1 parent ef12a4b commit 4ff05ae

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

‎ports/esp32/machine_uart.c‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ typedef struct _machine_uart_obj_t {
5252

5353
STATIC const char *_parity_name[] = {"None", "1", "0"};
5454

55-
QueueHandle_t UART_QUEUE[UART_NUM_MAX] = {};
56-
5755
/******************************************************************************/
5856
// MicroPython bindings for UART
5957

@@ -242,7 +240,7 @@ STATIC mp_obj_t machine_uart_make_new(const mp_obj_type_t *type, size_t n_args,
242240
uart_param_config(self->uart_num, &uartcfg);
243241

244242
// RX and TX buffers are currently hardcoded at 256 bytes each (IDF minimum).
245-
uart_driver_install(uart_num, 256, 256, 10, &UART_QUEUE[self->uart_num], 0);
243+
uart_driver_install(uart_num, 256, 256, 0, NULL, 0);
246244

247245
mp_map_t kw_args;
248246
mp_map_init_fixed_table(&kw_args, n_kw, args + n_args);

0 commit comments

Comments
 (0)