Skip to content

Commit 0004a84

Browse files
committed
Revert "Move gc_collect to py/gc.c"
This reverts commit a215b09.
1 parent baba08b commit 0004a84

3 files changed

Lines changed: 18 additions & 27 deletions

File tree

py/gc.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -187,22 +187,6 @@ void gc_collect_end(void) {
187187
gc_sweep();
188188
}
189189

190-
extern void gc_helper_get_regs_and_clean_stack(machine_uint_t *regs, machine_uint_t heap_end);
191-
192-
void gc_collect(void) {
193-
extern char _ram_start; /* defined by linker script */
194-
extern char _ram_end; /* defined by linker script */
195-
extern char _heap_start; /* defined by linker script */
196-
extern char _heap_end; /* defined by linker script */
197-
198-
gc_collect_start();
199-
gc_collect_root((void**)&_ram_start, (&_heap_start - &_ram_start) / 4);
200-
machine_uint_t regs[10];
201-
gc_helper_get_regs_and_clean_stack(regs, (uint32_t) &_heap_end);
202-
gc_collect_root((void**)&_heap_end, (&_ram_end - &_heap_end) / 4); // will trace regs since they now live in this function on the stack
203-
gc_collect_end();
204-
}
205-
206190
void gc_info(gc_info_t *info) {
207191
info->total = (gc_pool_end - gc_pool_start) * sizeof(machine_uint_t);
208192
info->used = 0;

stm/main.c

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
int errno;
4949

5050
extern uint32_t _heap_start;
51-
extern uint32_t _heap_end;
5251

5352
static FATFS fatfs0;
5453

@@ -456,12 +455,21 @@ bool do_file(const char *filename) {
456455
}
457456
}
458457

459-
mp_obj_t pyb_gc(void) {
460-
uint32_t start,ticks;
458+
#define RAM_START (0x20000000) // fixed for chip
459+
#define HEAP_END (0x2001c000) // tunable
460+
#define RAM_END (0x20020000) // fixed for chip
461461

462-
start = sys_tick_counter;
463-
gc_collect();
464-
ticks = sys_tick_counter - start; // TODO implement a function that does this properly
462+
void gc_helper_get_regs_and_clean_stack(machine_uint_t *regs, machine_uint_t heap_end);
463+
464+
void gc_collect(void) {
465+
uint32_t start = sys_tick_counter;
466+
gc_collect_start();
467+
gc_collect_root((void**)RAM_START, (((uint32_t)&_heap_start) - RAM_START) / 4);
468+
machine_uint_t regs[10];
469+
gc_helper_get_regs_and_clean_stack(regs, HEAP_END);
470+
gc_collect_root((void**)HEAP_END, (RAM_END - HEAP_END) / 4); // will trace regs since they now live in this function on the stack
471+
gc_collect_end();
472+
uint32_t ticks = sys_tick_counter - start; // TODO implement a function that does this properly
465473

466474
if (0) {
467475
// print GC info
@@ -472,7 +480,10 @@ mp_obj_t pyb_gc(void) {
472480
printf(" %lu : %lu\n", info.used, info.free);
473481
printf(" 1=%lu 2=%lu m=%lu\n", info.num_1block, info.num_2block, info.max_block);
474482
}
483+
}
475484

485+
mp_obj_t pyb_gc(void) {
486+
gc_collect();
476487
return mp_const_none;
477488
}
478489

@@ -598,7 +609,7 @@ int main(void) {
598609
soft_reset:
599610

600611
// GC init
601-
gc_init(&_heap_start, &_heap_end);
612+
gc_init(&_heap_start, (void*)HEAP_END);
602613

603614
// Micro Python init
604615
qstr_init();

stm/stm32f405.ld

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ _minimum_heap_size = 16K;
1919
/* top end of the stack */
2020
_estack = ORIGIN(RAM) + LENGTH(RAM);
2121

22-
_ram_start = 0x20000000;
23-
_ram_end = 0x20020000;
24-
_heap_end = 0x2001c000;
25-
2622
/* define output sections */
2723
SECTIONS
2824
{

0 commit comments

Comments
 (0)