[ENG-916] update gem from new oas - #15
Merged
glebedel merged 16 commits intoAug 30, 2023
Merged
Conversation
|
✅ Linked to Story ENG-916 · Separate employment type from employment contract |
jrebocho
reviewed
Aug 28, 2023
|
|
||
| module StackOneHRIS | ||
| # The employment work schedule type (e.g., full-time, part-time) | ||
| class EmploymentEmploymentContractType |
Contributor
There was a problem hiding this comment.
The names right now are not consistent, maybe we need to take a look at the OAS to make improve this.
jrebocho
reviewed
Aug 28, 2023
| require 'time' | ||
|
|
||
| module StackOneHRIS | ||
| class HrisCreateEmployeeRequestDto |
Contributor
There was a problem hiding this comment.
This should not probably be named in the lib Dto
jrebocho
reviewed
Aug 28, 2023
| :'zip_code' => :'String', | ||
| :'country' => :'CountryCodeEnum', | ||
| :'location_type' => :'LocationTypeEnum' | ||
| :'country' => :'LocationCountry', |
Contributor
There was a problem hiding this comment.
All the enum were named with the postfix Enum and were changed? 🤔
jrebocho
approved these changes
Aug 28, 2023
Contributor
There was a problem hiding this comment.
The changes LGTM and they don't seem to break any of the existing use cases. There are some changes that we need to review in the OAS, it seems that we are using different naming styles and conventions that should be addressed like naming enums or DTOs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like our OAS had significant changes since the last time we generated this gem (additional endpoints and more importantly change of model/entity names)
I used the openapi generator after bumping the gem version to 1.7 in the generator config. I then manually: