Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a .genignore file to prevent Speakeasy from regenerating the hooks.rb file and adds a require_relative './types' statement to import hook types in the hooks.rb file, likely following a Speakeasy recommendation to preserve custom hook type definitions.
Key Changes
- Added
lib/.genignorefile to exclude hooks.rb from automatic code regeneration - Added
require_relative './types'import statement to hooks.rb to load hook type definitions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/.genignore | Creates a new genignore file to prevent regeneration of hooks.rb by Speakeasy |
| lib/stack_one/sdk_hooks/hooks.rb | Adds import for types module to load hook type definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| lib/stack_one/sdk_hooks/hooks.rb No newline at end of file | |||
There was a problem hiding this comment.
The path in .genignore should be relative to the lib/ directory since this file is located at lib/.genignore. The current path lib/stack_one/sdk_hooks/hooks.rb appears to be an absolute path from the project root. Consider changing it to stack_one/sdk_hooks/hooks.rb if this file is intended to ignore generation for the hooks.rb file within the lib directory.
| lib/stack_one/sdk_hooks/hooks.rb | |
| stack_one/sdk_hooks/hooks.rb |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Summary by cubic
Exclude the Hooks file from code generation and restore hook types per Speakeasy guidance. Added lib/.genignore to ignore lib/stack_one/sdk_hooks/hooks.rb, and require_relative './types' in hooks.rb to load types and prevent generator overwrites.
Written for commit 0fb87b6. Summary will update automatically on new commits.