chore: 🐝 Update SDK - Generate 0.39.3 - #134
Merged
Merged
Conversation
* `stack_one.hris.get_employee()`: `response.data` **Changed** **Breaking**⚠️ * `stack_one.hris.list_employees()`: `response.data.[]` **Changed** **Breaking**⚠️ * `stack_one.ats.create_interview_note()`: **Added** * `stack_one.ats.update_interview_note()`: **Added** * `stack_one.lms.update_content()`: **Deleted** **Breaking**⚠️ * `stack_one.accounts.update_account()`: * `request.patch_account_external_dto.integration_id` **Added** * `stack_one.connect_sessions.authenticate_connect_session()`: `response.integration_id` **Added** * `stack_one.connect_sessions.create_connect_session()`: * `request.integration_id` **Added** * `response.integration_id` **Added** * `stack_one.hris.get_employee_employment()`: `response.data.manager.[]` **Changed** * `stack_one.hris.get_employment()`: `response.data.manager.[]` **Changed** * `stack_one.hris.list_employee_employments()`: `response.data.[].manager.[]` **Changed** * `stack_one.hris.list_employments()`: `response.data.[].manager.[]` **Changed**
There was a problem hiding this comment.
2 issues found across 82 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="lib/crystalline/types.rb">
<violation number="1" location="lib/crystalline/types.rb:49">
P1: Initialize super check misses superclass initializers; may skip required setup.</violation>
<violation number="2" location="lib/crystalline/types.rb:74">
P3: Raise a specific error class (ArgumentError) for invalid enum values.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| if @mapping.include? val | ||
| @mapping[val] | ||
| else | ||
| raise "Invalid value for enum: #{val}" |
There was a problem hiding this comment.
P3: Raise a specific error class (ArgumentError) for invalid enum values.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At lib/crystalline/types.rb, line 74:
<comment>Raise a specific error class (ArgumentError) for invalid enum values.</comment>
<file context>
@@ -41,38 +41,43 @@ class Boolean
+ if @mapping.include? val
+ @mapping[val]
+ else
+ raise "Invalid value for enum: #{val}"
end
- @mapping[instance.serialize] = instance
</file context>
Suggested change
| raise "Invalid value for enum: #{val}" | |
| raise ArgumentError, "Invalid value for enum: #{val}" |
| def initialize(val) | ||
| puts methods | ||
| if instance_methods(false).include?(:initialize) | ||
| if self.class.instance_methods(false).include?(:initialize) |
There was a problem hiding this comment.
P1: Initialize super check misses superclass initializers; may skip required setup.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At lib/crystalline/types.rb, line 49:
<comment>Initialize super check misses superclass initializers; may skip required setup.</comment>
<file context>
@@ -41,38 +41,43 @@ class Boolean
def initialize(val)
- puts methods
- if instance_methods(false).include?(:initialize)
+ if self.class.instance_methods(false).include?(:initialize)
super(val)
else
</file context>
jrebocho
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Linting report available at: https://app.speakeasy.com/org/stackone/stackone/linting-report/9d582c6859323c73d32bcb1cd51a519d
OpenAPI Change report available at: https://app.speakeasy.com/org/stackone/stackone/changes-report/22fa0364bf9b10851754886d5dc9dbc1
SDK update
Versioning
Version Bump Type: [patch] - 🤖 (automated)
Ruby SDK Changes:
stack_one.hris.get_employee():response.dataChanged Breakingstack_one.hris.list_employees():response.data.[]Changed Breakingstack_one.ats.create_interview_note(): Addedstack_one.ats.update_interview_note(): Addedstack_one.lms.update_content(): Deleted Breakingstack_one.accounts.update_account():request.patch_account_external_dto.integration_idAddedstack_one.connect_sessions.authenticate_connect_session():response.integration_idAddedstack_one.connect_sessions.create_connect_session():request.integration_idAddedresponse.integration_idAddedstack_one.hris.get_employee_employment():response.data.manager.[]Changedstack_one.hris.get_employment():response.data.manager.[]Changedstack_one.hris.list_employee_employments():response.data.[].manager.[]Changedstack_one.hris.list_employments():response.data.[].manager.[]ChangedOpenAPI Change Summary
RUBY CHANGELOG
core: 3.11.4 - 2025-11-24
🐝 New Features
inferUnionDiscriminators: truein gen.yaml (commit by @mfbx9da4)unions: 0.1.2 - 2025-11-26
🐝 New Features
Based on Speakeasy CLI 1.665.0
Summary by cubic
Regenerated Ruby SDK to 0.39.3. Adds ATS interview note APIs, integration_id support in Connect Sessions and Accounts, updates HRIS manager fields, and removes LMS update_content; also fixes multipart array uploads.
New Features
Migration
Written for commit e95baca. Summary will update automatically on new commits.