🌱 Bump golang version in build image from 1.23.5-bullseye to 1.24.6-bullseye#314
Merged
🌱 Bump golang version in build image from 1.23.5-bullseye to 1.24.6-bullseye#314
Conversation
…lseye Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
d7c84e1 to
1810b61
Compare
jschoone
requested changes
Sep 22, 2025
Contributor
jschoone
left a comment
There was a problem hiding this comment.
Interesting, I tried the 1.24.6 locally but ended with the error. But now it seems to work, see https://github.com/SovereignCloudStack/cluster-stack-operator/actions/runs/17917369231
I added some suggestions to get rid of the warnings
Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff
approved these changes
Sep 22, 2025
Member
garloff
left a comment
There was a problem hiding this comment.
Looks good.
Whether that is the complete solution needs to be seen, but certainly nothing wrong with this change.
jschoone
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes CSO-0.2 img build failure: https://github.com/SovereignCloudStack/cluster-stack-operator/actions/runs/17912013752/job/50929794430
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: