Skip to content

Commit 5eed2ff

Browse files
benfrybenfry
committed
disable async image saving by default
1 parent 81d3f1f commit 5eed2ff

3 files changed

Lines changed: 22 additions & 15 deletions

File tree

‎core/src/processing/core/PGraphics.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,9 @@ public class PGraphics extends PImage implements PConstants {
718718

719719

720720
public PGraphics() {
721-
// Allows subclasses to override
721+
// In 3.1.2, giving up on the async image saving as the default
722+
hints[DISABLE_ASYNC_SAVEFRAME] = true;
723+
System.out.println("disabling async saveFrame");
722724
}
723725

724726

‎core/todo.txt‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ X rewrite csv handling
33
X fix parsing bugs, remove newlines option, improve performance
44
X prevent random(low, high) from returning 'high'
55
X https://github.com/processing/processing/issues/4551
6+
X disable async saveFrame() by default
7+
X https://github.com/processing/processing/issues/4578
68

79
gohai
810
X Fix GLExceptions on Raspberry Pi when using offscreen PGraphics
@@ -23,18 +25,13 @@ X fix crash when calling getUniformLoc() called in PShader.set()
2325
X https://github.com/processing/processing/issues/4542
2426

2527

26-
_ disable async saveFrame() by default?
27-
_ https://github.com/processing/processing/issues/4578
28-
2928
_ Can't render PGraphics object using image() within a PDF
3029
_ https://github.com/processing/processing/issues/4473
3130

3231
_ JSONObject get() method is private
3332
_ https://github.com/processing/processing/issues/4334
3433
_ https://github.com/processing/processing/pull/4336
3534

36-
_ add push() and pop() methods to mirror js?
37-
3835
_ textAlign(CENTER) and pixelDensity(2) aligning incorrectly with Java2D
3936
_ https://github.com/processing/processing/issues/4020
4037
_ add increment() that takes IntDict to merge things
@@ -58,6 +55,11 @@ _ if not, need to add them to the block list
5855
_ the --hide-stop option not working (FX only? traces?)
5956

6057

58+
discussion
59+
_ add push() and pop() methods to mirror js?
60+
_ how to handle the touch api
61+
62+
6163
known
6264
_ window must close when using file dialogs with OpenGL on Windows
6365
_ https://github.com/processing/processing/issues/3831

‎todo.txt‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
0251 (3.1.2)
2-
2+
X update to Java 8u102 build 14
33

44
gohai
55
X IO: Fix drawing for SPIAnalogDigital examples
@@ -12,6 +12,9 @@ X IO: We want motors, they said (implements SoftwareServo)
1212
X https://github.com/processing/processing/pull/4546
1313
X Add a temporary workaround for the CHIP to deal with cursor problems
1414
X https://github.com/processing/processing/pull/4554
15+
X Fix the Downloader so that builds work again
16+
X https://github.com/processing/processing/issues/4496
17+
X https://github.com/processing/processing/pull/4511
1518

1619
jakub
1720
X Return of the error check toggle
@@ -29,16 +32,23 @@ X updates to Japanese translation
2932
X https://github.com/processing/processing/pull/4564
3033
X Make preferences button wider for Japanese
3134
X https://github.com/processing/processing/pull/4558
35+
X Show warning message if mode cannot be changed
36+
X https://github.com/processing/processing/pull/4559
3237

3338
fixed in 3.1.1
3439
X debugger deadlocks when choosing "Step Into" on println()
3540
X https://github.com/processing/processing/issues/3923
3641
X Suggestions switch scope to first import
3742
X https://github.com/processing/processing/issues/4016
43+
X loadImage() immediately after saveFrame() foiled by async default
44+
X https://github.com/processing/processing/issues/4218
45+
X the hint() mostly works, but gross to use a hint frequently
3846

3947

4048
high
41-
_ update to 8 102 14
49+
_ NullPointerException in SketchCode.getDocumentText()
50+
_ https://github.com/processing/processing/issues/4555
51+
_ https://github.com/processing/processing/pull/4547
4252
_ Pasting code from editor to empty editor produces Exception
4353
_ https://github.com/processing/processing/issues/4522
4454
_ did we lose settings.path because it was too buggy?
@@ -113,13 +123,6 @@ _ Tweak Mode sometimes freezes while running, require a force quit
113123
_ https://github.com/processing/processing/issues/3928
114124

115125

116-
discussion
117-
_ loadImage() immediately after saveFrame() foiled by async default
118-
_ https://github.com/processing/processing/issues/4218
119-
_ the hint() mostly works, but gross to use a hint frequently
120-
_ how to handle the touch api
121-
122-
123126
gui
124127
_ Tooltip over variable decl has wrong style and content
125128
_ make all tooltips run through our style

0 commit comments

Comments
 (0)