Update to Polymer 2, clean code and add auto build script#35
Open
myfrom wants to merge 5 commits intoSortableJS:masterfrom
Open
Update to Polymer 2, clean code and add auto build script#35myfrom wants to merge 5 commits intoSortableJS:masterfrom
myfrom wants to merge 5 commits intoSortableJS:masterfrom
Conversation
Made it simpler, more informative and better at finding files
|
Can't wait for this to be merged! Awesome work! |
Author
|
@dcbrwn Thanks 😄 You actually reminded me that I should update it to Polymer 3 as well 🤔 I'll look into it probably after I finish my current project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the beggining, I would like to say sorry that I didn't split this to smaller PRs but this repo hasn't been maintained for a while and I needed all of the changes to test their functionality.
What does this PR change?
Added support for Hybrid mode
This way developers can use this element in both Polymer 2.0 and 1.x
This fixes RubaXa/Sortable#1237
Added automatic build script
This helps the element to stay up to date with latest Sortable version. The framework sometimes changes options that it accepts, now running
build.jswill automatically add those options to the elements as parameters so they an be passed, I've described that deeper in CONTRIBUTING.mdUpdated for Sortable#1.6.0
Which also confirmed my script works 😃
I didn't use 1.7.0 because it's not available on Bower 😢
Changed .gitignore
This is really small change, I added a few VSCode files to be ignored and also removed ones like mock.png and /test which should not be ignored.
cc @RubaXa
PS: This repository hasn't been updated for a while, I guess it's because you might have no time for it. If it would be possible I could take care of this repository for you. I often work with Polymer, have plenty of free time and I'd love to help 👨💻️