Added type check for 'dragStarted' variable as this is causing thousa…#1689
Merged
owen-m1 merged 1 commit intoSortableJS:masterfrom Dec 5, 2019
kcak11:master
Merged
Added type check for 'dragStarted' variable as this is causing thousa…#1689owen-m1 merged 1 commit intoSortableJS:masterfrom kcak11:master
owen-m1 merged 1 commit intoSortableJS:masterfrom
kcak11:master
Conversation
…nds of console errors in Chrome, Firefox, Edge, IE, Safari before the first drag. This change is harmless because it is just checking if the variable dragStarted is declared before using it. Tested across all of the above browsers and working fine after this change.
Member
|
What is the error? The variable is declared as false at the start of the file. |
Author
Error: This is noticed before performing the first drag action on the Sortable elements. If the user clicks anywhere else in the neighbouring elements, then the above error is seen. |
Author
|
@owen-m1 any updates on merging this pull-request ? Thanks in advance. |
Author
|
@owen-m1 Do you need any more information to merge this pull request. Please let me know. |
Runi-c
pushed a commit
to Tupperbox/Sortable
that referenced
this pull request
Nov 10, 2023
Added type check for 'dragStarted' variable as this is causing thousa…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added type check for 'dragStarted' variable as this is causing thousands of console errors in Chrome, Firefox, Edge, IE, Safari before the first drag.
This change is harmless because it is just checking if the variable dragStarted is declared before using it.
Tested across all of the above browsers and working fine after this change.