Upgrade release workflow to v3 - #909
Merged
Merged
Conversation
guillaume-dequenne
approved these changes
Apr 29, 2021
guillaume-dequenne
left a comment
guillaume-dequenne
left a comment
Contributor
There was a problem hiding this comment.
Shouldn't we remove BINTRAY_USER BINTRAY_TOKEN CENTRAL_USER CENTRAL_PASSWORD and GPG_PASSPHRASE variables as well in release.yml?
lgtm otherwise
tomverin
requested changes
Apr 29, 2021
| echo "${{ steps.lt_release.outputs.releasability }}" | ||
| echo "${{ steps.lt_release.outputs.release }}" | ||
|
|
||
| maven-central-sync: |
Contributor
There was a problem hiding this comment.
Some env vars needs to be delete
BINTRAY_USER: ${{ secrets.BINTRAY_USER }}
BINTRAY_TOKEN: ${{ secrets.BINTRAY_TOKEN }}
CENTRAL_USER: ${{ secrets.CENTRAL_USER }}
CENTRAL_PASSWORD: ${{ secrets.CENTRAL_PASSWORD }}
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
|
SonarQube Quality Gate
|
tomverin
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.