Skip to content

Fix quality gate: Add @Nullable annotation #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrea-guarino-sonarsource merged 1 commit into from
Sep 13, 2019
Merged

Fix quality gate: Add @Nullable annotation #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python-squid/src/main/java/org/sonar/python/tree/PyAnnotatedAssignmentTreeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.Arrays;
import java.util.List;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
import org.sonar.python.api.tree.PyAnnotatedAssignmentTree;
import org.sonar.python.api.tree.PyExpressionTree;
import org.sonar.python.api.tree.PyTreeVisitor;
Expand All @@ -35,7 +36,7 @@ public class PyAnnotatedAssignmentTreeImpl extends PyTree implements PyAnnotated
private final Token equalToken;
private final PyExpressionTree assignedValue;

public PyAnnotatedAssignmentTreeImpl(PyExpressionTree variable, Token colonToken, PyExpressionTree annotation, Token equalToken, PyExpressionTree assignedValue) {
public PyAnnotatedAssignmentTreeImpl(PyExpressionTree variable, Token colonToken, PyExpressionTree annotation, Token equalToken, @Nullable PyExpressionTree assignedValue) {
super(variable.firstToken(), assignedValue != null ? assignedValue.lastToken() : annotation.lastToken());
this.variable = variable;
this.colonToken = colonToken;
Expand Down
5 changes: 3 additions & 2 deletions python-squid/src/main/java/org/sonar/python/tree/PyArgumentTreeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.List;
import java.util.Arrays;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
import org.sonar.python.api.tree.PyArgumentTree;
import org.sonar.python.api.tree.PyExpressionTree;
import org.sonar.python.api.tree.PyNameTree;
Expand All @@ -37,7 +38,7 @@ public class PyArgumentTreeImpl extends PyTree implements PyArgumentTree {
private final Token star;
private final Token starStar;

public PyArgumentTreeImpl(AstNode node, PyNameTree keywordArgument, PyExpressionTree expression, Token equalToken, AstNode star, AstNode starStar) {
public PyArgumentTreeImpl(AstNode node, PyNameTree keywordArgument, PyExpressionTree expression, Token equalToken, @Nullable AstNode star, @Nullable AstNode starStar) {
super(node);
this.keywordArgument = keywordArgument;
this.expression = expression;
Expand All @@ -46,7 +47,7 @@ public PyArgumentTreeImpl(AstNode node, PyNameTree keywordArgument, PyExpression
this.starStar = starStar != null ? starStar.getToken() : null;
}

public PyArgumentTreeImpl(AstNode astNode, PyExpressionTree expression, AstNode star, AstNode starStar) {
public PyArgumentTreeImpl(AstNode astNode, PyExpressionTree expression, @Nullable AstNode star, @Nullable AstNode starStar) {
super(astNode);
this.keywordArgument = null;
this.expression = expression;
Expand Down
3 changes: 2 additions & 1 deletion python-squid/src/main/java/org/sonar/python/tree/PyDecoratorTreeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.Arrays;
import java.util.List;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
import org.sonar.python.api.tree.PyArgListTree;
import org.sonar.python.api.tree.PyDecoratorTree;
import org.sonar.python.api.tree.PyDottedNameTree;
Expand All @@ -37,7 +38,7 @@ public class PyDecoratorTreeImpl extends PyTree implements PyDecoratorTree {
private final PyArgListTree argListTree;
private final Token rPar;

public PyDecoratorTreeImpl(AstNode astNode, Token atToken, PyDottedNameTree dottedName, AstNode lPar, PyArgListTree argListTree, AstNode rPar) {
public PyDecoratorTreeImpl(AstNode astNode, Token atToken, PyDottedNameTree dottedName, @Nullable AstNode lPar, PyArgListTree argListTree, @Nullable AstNode rPar) {
super(astNode);
this.atToken = atToken;
this.dottedName = dottedName;
Expand Down
3 changes: 2 additions & 1 deletion python-squid/src/main/java/org/sonar/python/tree/PyExceptClauseTreeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.util.Arrays;
import java.util.List;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
import org.sonar.python.api.tree.PyExceptClauseTree;
import org.sonar.python.api.tree.PyExpressionTree;
import org.sonar.python.api.tree.PyStatementListTree;
Expand All @@ -48,7 +49,7 @@ public PyExceptClauseTreeImpl(Token exceptKeyword, PyStatementListTree body) {
this.exceptionInstance = null;
}

public PyExceptClauseTreeImpl(Token exceptKeyword, PyStatementListTree body, PyExpressionTree exception, AstNode asNode, AstNode commaNode, PyExpressionTree exceptionInstance) {
public PyExceptClauseTreeImpl(Token exceptKeyword, PyStatementListTree body, PyExpressionTree exception, @Nullable AstNode asNode, @Nullable AstNode commaNode, PyExpressionTree exceptionInstance) {
super(exceptKeyword, body.lastToken());
this.exceptKeyword = exceptKeyword;
this.body = body;
Expand Down
3 changes: 2 additions & 1 deletion python-squid/src/main/java/org/sonar/python/tree/PyImportFromTreeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
import org.sonar.python.api.PythonPunctuator;
import org.sonar.python.api.tree.PyAliasedNameTree;
import org.sonar.python.api.tree.PyDottedNameTree;
Expand All @@ -42,7 +43,7 @@ public class PyImportFromTreeImpl extends PyTree implements PyImportFromTree {
private final boolean isWildcardImport;
private final Token wildcard;

public PyImportFromTreeImpl(AstNode astNode, Token fromKeyword, List<Token> dottedPrefixForModule, PyDottedNameTree moduleName, Token importKeyword, List<PyAliasedNameTree> aliasedImportNames, boolean isWildcardImport) {
public PyImportFromTreeImpl(AstNode astNode, Token fromKeyword, List<Token> dottedPrefixForModule, PyDottedNameTree moduleName, Token importKeyword, @Nullable List<PyAliasedNameTree> aliasedImportNames, boolean isWildcardImport) {
super(astNode);
this.fromKeyword = fromKeyword;
this.dottedPrefixForModule = dottedPrefixForModule;
Expand Down