Location: php:php-checks/src/test/java/org/sonar/php/checks/AvoidDESCheckTest.java:25

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the defaultValue() method in AvoidDESCheckTest.java. The method body does not actually throw any checked Exception, so the throws clause was unnecessary. This fixes the code smell where a thrown exception is declared but cannot actually be thrown from the method's body.

--- a/php-checks/src/test/java/org/sonar/php/checks/AvoidDESCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/AvoidDESCheckTest.java
@@ -25,1 +25,1 @@ class AvoidDESCheckTest {
-  void defaultValue() throws Exception {
+  void defaultValue() {

Location: php:php-checks/src/test/java/org/sonar/php/checks/LocalVariableShadowsClassFieldCheckTest.java:25

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the test method 'test()' in LocalVariableShadowsClassFieldCheckTest.java. The method body does not actually throw any checked exception, so declaring 'throws Exception' is unnecessary and reduces code readability. By changing the method signature from 'void test() throws Exception' to 'void test()', the code smell about a declared thrown exception that cannot be thrown from the method's body is resolved.

--- a/php-checks/src/test/java/org/sonar/php/checks/LocalVariableShadowsClassFieldCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/LocalVariableShadowsClassFieldCheckTest.java
@@ -25,1 +25,1 @@ class LocalVariableShadowsClassFieldCheckTest {
-  void test() throws Exception {
+  void test() {

Location: php:php-checks/src/test/java/org/sonar/php/checks/SSLHostVerificationDisabledCheckTest.java:24

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the test() method signature. The method body does not actually throw any checked exception, so declaring 'throws Exception' is unnecessary and reduces code readability. This directly addresses the code smell about removing declarations of thrown exceptions that cannot be thrown from the method's body.

--- a/php-checks/src/test/java/org/sonar/php/checks/SSLHostVerificationDisabledCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/SSLHostVerificationDisabledCheckTest.java
@@ -24,1 +24,1 @@ class SSLHostVerificationDisabledCheckTest {
-  void test() throws Exception {
+  void test() {

Location: php:php-checks/src/test/java/org/sonar/php/checks/phpini/FileUploadsCheckTest.java:38

Why is this an issue?

Superfluous exceptions within throws clauses have negative effects on the readability and maintainability of the code. An exception in a throws clause is superfluous if it is:

What changed

Removes the superfluous 'throws Exception' declaration from the 'fileIssue()' method, since no exception is actually thrown from the method's body. This addresses the code smell where a throws clause declares an exception that cannot be thrown by any execution path of the method.

--- a/php-checks/src/test/java/org/sonar/php/checks/phpini/FileUploadsCheckTest.java
+++ b/php-checks/src/test/java/org/sonar/php/checks/phpini/FileUploadsCheckTest.java
@@ -38,1 +38,1 @@ class FileUploadsCheckTest {
-  void fileIssue() throws Exception {
+  void fileIssue() {

Location: php:php-checks/src/main/java/org/sonar/php/checks/RepeatedComplementOperatorCheck.java:45

Why is this an issue?

If all the keys in a Map are values from a single enum, it is recommended to use an EnumMap as the specific implementation. An EnumMap, which has the advantage of knowing all possible keys in advance, is more efficient compared to other implementations, as it can use a simple array as its underlying data structure.

What changed

Replaces the import of HashMap with EnumMap to support the change from using a HashMap to an EnumMap for a Map whose keys are enum values (Kind). This is necessary for the code to compile after the main fix in the other hunk.

--- a/php-checks/src/main/java/org/sonar/php/checks/RepeatedComplementOperatorCheck.java
+++ b/php-checks/src/main/java/org/sonar/php/checks/RepeatedComplementOperatorCheck.java
@@ -19,1 +19,1 @@ package org.sonar.php.checks;
-import java.util.HashMap;
+import java.util.EnumMap;