SONARJAVA-5730

Summary

Improve S1301 rule to detect non-exhaustive switches over enums. Previously, the rule skipped reporting violations on all enum switches without a default case, assuming compiler exhaustiveness would catch missing cases. This fix refines the logic to only skip reporting when the switch actually covers all enum constants. Switches over enums with many constants but only a few cases are now properly flagged, improving code quality detection for partial enum handling that shouldn't rely on compiler checks.

What reviewers should know

The key change is in SwitchAtLeastThreeCasesCheck.java lines 56-63: the condition now checks enumConstantCount(typeSymbol) == count to verify the switch is truly exhaustive. The new enumConstantCount() method filters for actual enum constants while excluding fields/methods defined in the enum body. New test cases demonstrate the fix: a 7-constant enum with 1 case is now Noncompliant, while a 2-constant enum with 2 cases remains Compliant (exhaustive). Focus review on whether the enum constant counting logic correctly identifies only the enum constants and not other enum members.

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube