SONARJAVA-3727 Update rules metadata #3496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentin-jaquier-sonarsource
approved these changes
Mar 19, 2021
Contributor
quentin-jaquier-sonarsource
left a comment
quentin-jaquier-sonarsource
left a comment
There was a problem hiding this comment.
Two problems with list formatting, I already fixed both of them, you can simply re-generate the descriptions.
| <li> <a href="https://www.owasp.org/index.php/Top_10-2017_A6-Security_Misconfiguration">OWASP Top 10 2017 Category A6</a> - Security | ||
| Misconfiguration </li> | ||
| </ul> | ||
| <p> * <a href="https://www.owasp.org/index.php/Top_10-2017_A6-Security_Misconfiguration">OWASP Top 10 2017 Category A6</a> - Security |
Contributor
There was a problem hiding this comment.
This should be a list, I already fixed it in the description.
Comment on lines
2
to
4
| <p>- not vulnerable to <code>brute force attacks</code>.</p> | ||
| <p>- not vulnerable to <code>collision attacks</code> (see rule s4790).</p> | ||
| <p>- and a salt should be added to the password to lower the risk of <code>rainbow table attacks</code> (see rule s2053).</p> |
Contributor
There was a problem hiding this comment.
This should be a list aswell.
alban-auzeill
force-pushed
the
SONARJAVA-3727
branch
from
80e7362 to
cc7d58f
Compare
alban-auzeill
force-pushed
the
SONARJAVA-3727
branch
from
cc7d58f to
105b879
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.