SONARJAVA-3648 S2384: Skip assignment checks in enum constructors (#3450)

dorian-burihabwa-sonarsource · web-flow · commit ab3b22e92eb3 · 2021-02-19T14:15:12.000+01:00
diff --git a/java-checks-test-sources/src/main/java/checks/MutableMembersUsageCheck.java b/java-checks-test-sources/src/main/java/checks/MutableMembersUsageCheck.java
@@ -298,3 +298,21 @@ private static ImmutableCollection<String> getImmutableCollection() {
     return null;
   }
 }
+
+enum MyEnumWithAMutableMember {
+  ELEMENT(new int[]{0, 1, 2});
+
+  private final int[] arg;
+
+  MyEnumWithAMutableMember(int[] arg) {
+    this.arg = arg; // Compliant
+  }
+}
+
+class MyClassWithAMutableMember {
+  private final int[] arg;
+
+  MyClassWithAMutableMember(int[] arg) {
+    this.arg = arg; // Noncompliant
+  }
+}
diff --git a/java-checks/src/main/java/org/sonar/java/checks/MutableMembersUsageCheck.java b/java-checks/src/main/java/org/sonar/java/checks/MutableMembersUsageCheck.java
@@ -72,6 +72,12 @@ public void scanFile(final JavaFileScannerContext context) {
 
   @Override
   public void visitMethod(MethodTree tree) {
+    if (tree.is(Tree.Kind.CONSTRUCTOR)) {
+      Symbol.TypeSymbol enclosingClass = tree.symbol().enclosingClass();
+      if (enclosingClass.isEnum()) {
+        return;
+      }
+    }
     ArrayList<Symbol> parameters = new ArrayList<>();
     for (VariableTree variableTree : tree.parameters()) {
       parameters.add(variableTree.symbol());
diff --git a/java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2384_java.html b/java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2384_java.html
@@ -56,7 +56,6 @@ <h2>Compliant Solution</h2>
     a.getStrings()[0] = "yellow";  // a.strings = {"first", "second"};
   }
 }
-
 </pre>
 <h2>See</h2>
 <ul>

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ <h2>Compliant Solution</h2>`
`56`	`56`	`a.getStrings()[0] = "yellow"; // a.strings = {"first", "second"};`
`57`	`57`	`}`
`58`	`58`	`}`
`59`		`-`
`60`	`59`	`</pre>`
`61`	`60`	`<h2>See</h2>`
`62`	`61`	`<ul>`