remove internal usage of solace_message#18
Merged
TamimiGitHub merged 4 commits intomasterfrom Nov 30, 2021
Merged
Conversation
patterns/hello_world_pubsub.py
Outdated
| # Modifying the outbond message instead of creating a new one | ||
| outbound_msg.solace_message.message_set_binary_attachment_string(f'{message_body} --> {msgSeqNum}') | ||
| outbound_msg.solace_message.set_message_application_message_id(f'sample_id {msgSeqNum}') | ||
| time.sleep(0.1) |
There was a problem hiding this comment.
time.sleep should not be necessary when using back the default back pressure elastic. Why is this here?
Contributor
Author
There was a problem hiding this comment.
I had it for demo purposes to show better show the flow of messages. I have however commented it out but kept it in case
patterns/hello_world_pubsub.py
Outdated
| time.sleep(0.1) | ||
| # Check https://docs.solace.com/API-Developer-Online-Ref-Documentation/python/source/rst/solace.messaging.config.solace_properties.html for additional message properties | ||
| additional_properties = {APPLICATION_MESSAGE_ID: f'sample_id {msgSeqNum}'} | ||
| # Creating a dynamic outbond message |
| # Check https://docs.solace.com/API-Developer-Online-Ref-Documentation/python/source/rst/solace.messaging.config.solace_properties.html for additional message properties | ||
| additional_properties = {APPLICATION_MESSAGE_ID: f'sample_id {msgSeqNum}'} | ||
| # Creating a dynamic outbond message | ||
| outbound_message = message_builder.build(f'{message_body} --> {msgSeqNum}', additional_message_properties=additional_properties) |
There was a problem hiding this comment.
Might be nice to comment that applciation id is override from the value of set in the builder?
Contributor
Author
There was a problem hiding this comment.
yeah that's a good idea 👍 will add it now
Contributor
Author
|
I'll go ahead and merge this + add a 1.2 tag to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.