Conversation
…improved build script
dacoburn
requested review from
bmeck and
mikolalysenko
and removed request for
a team
obarrera
approved these changes
Oct 18, 2024
mikolalysenko
approved these changes
Oct 30, 2024
Contributor
mikolalysenko
left a comment
mikolalysenko
left a comment
There was a problem hiding this comment.
Seems fine, but we should probably pull these glob patterns from the API instead of hard coding them. @bcomnes do we have an API for this?
Contributor
If we do have an API for this, or even just an established pattern for generating the glob patterns in the JS sdk, I can incorporate that into the changes I'm working on right now. I'm working through the cli, replacing all the direct API calls with the associated methods from the python SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…improved build script