fix(optimize): correct backwards semver check of node version#759
Closed
Uniqen wants to merge 60 commits intoSocketDev:mainfrom
Closed
fix(optimize): correct backwards semver check of node version#759Uniqen wants to merge 60 commits intoSocketDev:mainfrom
Uniqen wants to merge 60 commits intoSocketDev:mainfrom
Conversation
Contributor
|
Merging in manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I investigated why no packages was installed when using socket optimize. According to Copilot the issue is that the semver logic in
add-overrides.mtsis backwards. When applying the fix all packages are installed as expected.