Skip to content

AQS对资源共享方式的非公平锁表述错误 #569

Closed

Description

@WeiKangJian

原文中是当线程要获取锁时,无视队列顺序直接去抢锁,谁抢到就是谁的。
实际上源码中是当该锁释放时候,新来的线程和队列中第一个线程进行竞争,如果失败,加入到等待队列中去,对于队列中的所有等待线程依然是FIFO的。不公平是新线程相对于等待队列中的线程。原文的表述方式可能让读者误解非公平锁的实现方式

Activity

  1. jqh924 commented on Nov 26, 2019

    @jqh924
  2. LiWenGu commented on Nov 26, 2019

    @LiWenGu
    Contributor

    确实是这样
    JDK1.8

    static final class NonfairSync extends Sync {
        private static final long serialVersionUID = 7316153563782823691L;
    
        /**
         * Performs lock.  Try immediate barge, backing up to normal
         * acquire on failure.
         */
        final void lock() {
            // 通过CAS改状态,其实就是和队列里的头抢锁
            if (compareAndSetState(0, 1))
                setExclusiveOwnerThread(Thread.currentThread());
            else
                // 如果抢失败了,就执行正常的 AQS 逻辑,即入队列,等唤醒
                acquire(1);
        }
    
        protected final boolean tryAcquire(int acquires) {
            return nonfairTryAcquire(acquires);
        }
    }

    原文中是当线程要获取锁时,无视队列顺序直接去抢锁,谁抢到就是谁的。
    实际上源码中是当该锁释放时候,新来的线程和队列中第一个线程进行竞争,如果失败,加入到等待队列中去,对于队列中的所有等待线程依然是FIFO的。不公平是新线程相对于等待队列中的线程。原文的表述方式可能让读者误解非公平锁的实现方式

  3. Snailclimb commented on Nov 26, 2019

    @Snailclimb
    Owner

    赞!!!感谢各位大佬!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions