Fixed stderr/-out/-in redirection. (theskumar#145)

venthur · theskumar · commit 3b7e60e6cbde · 2018-10-31T17:02:00.000+05:30
Closes: theskumar#137
diff --git a/dotenv/main.py b/dotenv/main.py
@@ -7,7 +7,7 @@
 import os
 import re
 import sys
-from subprocess import Popen, PIPE, STDOUT
+from subprocess import Popen
 import warnings
 from collections import OrderedDict
 
@@ -293,19 +293,10 @@ def run_command(command, env):
     cmd_env.update(env)
 
     p = Popen(command,
-              stdin=PIPE,
-              stdout=PIPE,
-              stderr=STDOUT,
               universal_newlines=True,
               bufsize=0,
               shell=False,
               env=cmd_env)
-    try:
-        out, _ = p.communicate()
-        print(out)
-    except Exception:
-        warnings.warn('An error occured, running the command:')
-        out, _ = p.communicate()
-        warnings.warn(out)
+    _, _ = p.communicate()
 
     return p.returncode
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -210,10 +210,14 @@ def test_run(cli):
         assert result == 'BAR'
 
 
-def test_run_with_other_env(cli, dotenv_file):
-    cli.invoke(dotenv_cli, ['--file', dotenv_file, 'set', 'FOO', "BAR"])
-    result = cli.invoke(dotenv_cli, ['--file', dotenv_file, 'run', 'printenv', 'FOO'])
-    assert result.output.strip() == 'BAR'
+def test_run_with_other_env(cli):
+    DOTENV_FILE = 'dotenv'
+    with cli.isolated_filesystem():
+        sh.cd(here)
+        sh.touch(DOTENV_FILE)
+        sh.dotenv('--file', DOTENV_FILE, 'set', 'FOO', 'BAR')
+        result = sh.dotenv('--file', DOTENV_FILE, 'run', 'printenv', 'FOO').strip()
+        assert result == 'BAR'
 
 
 def test_run_without_cmd(cli):
