Skip to content

fix(credstore): default activate URL → api.meter.skillbench.com - #69

Merged
minarc merged 1 commit into
mainfrom
fix/activate-url-default
Jun 10, 2026
Merged

minarc merged 1 commit into
mainfrom
fix/activate-url-default

Conversation

@minarc

@minarc minarc commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

What

Change the hardcoded DEFAULT_ACTIVATE_URL in lib/license-activation.js (and the README env-var table) from https://api.skillbench.com/activate to https://api.meter.skillbench.com/activate.

Why

api.skillbench.com has no DNS record — confirmed NXDOMAIN against the skillbench.com Route53 zone. The activation flow traced end-to-end as:

POST /activate
  → api.meter.skillbench.com   (the actual prod custom domain)
  → API Gateway v2  ApiId=mdan8egxab  ($default)
  → λ control-plane-prod-license-activation  (provided.al2023, ap-southeast-2)

Any user who did not override SKILLMETER_ACTIVATE_URL / skillmeter.activate_url would hit a DNS failure on activation. This points the default at the host that actually fronts the /activate route.

Changes

  • skillmeter/scripts/lib/license-activation.js — default URL
  • skillmeter/README.md — env-var table default

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the license activation endpoint configuration across documentation and system implementation to reflect the new activation service location. The default fallback endpoint has been adjusted to route to the updated service URL when no custom activation endpoint is explicitly specified.

The hardcoded DEFAULT_ACTIVATE_URL was https://api.skillbench.com/activate,
but that hostname has no DNS record (NXDOMAIN) — confirmed against the
skillbench.com Route53 zone. The real prod custom domain that fronts the
POST /activate route (API mdan8egxab -> control-plane-prod-license-activation
Lambda) is api.meter.skillbench.com.

Anyone who didn't override SKILLMETER_ACTIVATE_URL / skillmeter.activate_url
would hit a DNS failure on activation. Update the code default and the README
env-var table to the working host.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@minarc
minarc merged commit 744b2c2 into main Jun 10, 2026
1 check was pending
@minarc
minarc deleted the fix/activate-url-default branch June 10, 2026 08:43
@coderabbitai

coderabbitai Bot commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52072654-0324-4007-ac09-c4eac6d526a9

📥 Commits

Reviewing files that changed from the base of the PR and between cd002c5 and 2406738.

📒 Files selected for processing (2)
  • skillmeter/README.md
  • skillmeter/scripts/lib/license-activation.js

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

This PR updates the default license activation endpoint from api.skillbench.com/activate to api.meter.skillbench.com/activate in both the implementation constant and the corresponding README configuration documentation.

Changes

Activation endpoint subdomain migration

Layer / File(s) Summary
Default activation endpoint update
skillmeter/scripts/lib/license-activation.js
DEFAULT_ACTIVATE_URL constant changed to https://api.meter.skillbench.com/activate as the fallback endpoint when environment variable or project settings are not provided.
Configuration documentation update
skillmeter/README.md
Documentation for SKILLMETER_ACTIVATE_URL environment variable updated to document the new api.meter.skillbench.com subdomain as the default activation endpoint.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • SkillBench-AI/skillmeter-claude-code-marketplace#67: The main PR updates license-activation.getActivateUrl()'s fallback endpoint (and its docs) to https://api.meter.skillbench.com/activate, which directly builds on the retrieved PR's creation of lib/license-activation.js and its original fallback https://api.skillbench.com/activate.
  • SkillBench-AI/skillmeter-claude-code-marketplace#36: Both PRs align the SkillMeter license activation "activate" endpoint to https://api.meter.skillbench.com/activate—main PR updates the getActivateUrl() fallback in license-activation.js, while the retrieved PR uses the same endpoint via ACTIVATE_URL for its silent GitHub activation flow.
  • SkillBench-AI/skillmeter-claude-code-marketplace#59: The main PR's change to the default getActivateUrl()/activation fallback endpoint (switching the hardcoded default) is directly related to PR #59's activation URL resolver work in credstore, which introduced getActivateUrl() and a default activation URL.

Suggested reviewers

  • jhunlee-dev

Poem

🐰 A hop through the meter-domain lane,
Where endpoints now dance with a sub domain refrain,
From api.skillbench to meter.skillbench we bound,
Two tiny edits, but the routing is sound! 🎯

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/activate-url-default

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.22.0)

OpenGrep fatal error (exit code 2):
┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m
[00.20][ERROR]: Error: exception Glob.Lexer.Syntax_error("malformed glob pattern: missing ']'")
Raised at Glob__Lexer.syntax_error in file "libs/glob/Lexer.mll", line 8, characters 2-26
Called from Glob__Lexer.__ocaml_lex_token_rec in file "libs/glob/Lexer.mll", line 29, characters 26-53
Cal


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant