Repository navigation
fix(credstore): default activate URL → api.meter.skillbench.com - #69
Conversation
The hardcoded DEFAULT_ACTIVATE_URL was https://api.skillbench.com/activate, but that hostname has no DNS record (NXDOMAIN) — confirmed against the skillbench.com Route53 zone. The real prod custom domain that fronts the POST /activate route (API mdan8egxab -> control-plane-prod-license-activation Lambda) is api.meter.skillbench.com. Anyone who didn't override SKILLMETER_ACTIVATE_URL / skillmeter.activate_url would hit a DNS failure on activation. Update the code default and the README env-var table to the working host. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
WalkthroughThis PR updates the default license activation endpoint from ChangesActivation endpoint subdomain migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.22.0)OpenGrep fatal error (exit code 2): �[32m✔�[39m �[1mOpengrep OSS�[0m �[1m Loading rules from local config...�[0m Comment |
What
Change the hardcoded
DEFAULT_ACTIVATE_URLinlib/license-activation.js(and the README env-var table) fromhttps://api.skillbench.com/activatetohttps://api.meter.skillbench.com/activate.Why
api.skillbench.comhas no DNS record — confirmedNXDOMAINagainst theskillbench.comRoute53 zone. The activation flow traced end-to-end as:Any user who did not override
SKILLMETER_ACTIVATE_URL/skillmeter.activate_urlwould hit a DNS failure on activation. This points the default at the host that actually fronts the/activateroute.Changes
skillmeter/scripts/lib/license-activation.js— default URLskillmeter/README.md— env-var table default🤖 Generated with Claude Code
Summary by CodeRabbit