Repository navigation
revert(signin): drop short-poll, guide user to re-run /skillmeter:signin (v0.12.4) - #64
Conversation
…nin (v0.12.4) The v0.12.3 short-poll loop tried to surface the welcome banner without the user re-invoking the slash command, but the UX gain wasn't worth the extra complexity (poll-state file, lifecycle bookkeeping). Revert the short-poll feature and replace it with a clearer three-step instruction in the expansion hook's RUN_INSTRUCTION so the user knows exactly what to do after device-flow auth completes: 1. Paste the `!`-prefixed signin command 2. Approve in the browser 3. Re-run /skillmeter:signin to confirm and see the banner Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Disabled knowledge base sources:
WalkthroughBackground device-flow polling switches from sentinel-file-based lifecycle tracking ( ChangesSign-in polling and credential caching simplification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 OpenGrep (1.20.0)OpenGrep fatal error (exit code 2): �[32m✔�[39m �[1mOpengrep OSS�[0m �[1m Loading rules from local config...�[0m Comment |
Summary
The
v0.12.3short-poll loop tried to surface the welcome banner without the user re-invoking the slash command, but the UX gain wasn't worth the extra complexity (poll-state file, lifecycle bookkeeping). This PR reverts the short-poll feature and replaces it with a clearer three-step instruction in the expansion hook'sRUN_INSTRUCTIONso the user knows exactly what to do after device-flow auth completes:!-prefixed signin command/skillmeter:signinto confirm and see the welcome bannerChanges
skillmeter/scripts/lib/poll-state.jscredstore.js,signin.js, and the expansion hookRUN_INSTRUCTIONinuser_prompt_expansion_signin.jsas a numbered three-step guideplugin.json0.12.3 → 0.12.4Test plan
/skillmeter:signoutthen/skillmeter:signinwith no gh auth → expect Claude to relay the new three-step instruction!command, complete GitHub auth, re-run/skillmeter:signin→ welcome banner renderspoll-state.jsremain in any script🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation
Refactor