Skip to content

revert(signin): drop short-poll, guide user to re-run /skillmeter:signin (v0.12.4) - #64

Merged
minarc merged 1 commit into
mainfrom
feat/signin-short-poll-banner
May 16, 2026
Merged

minarc merged 1 commit into
mainfrom
feat/signin-short-poll-banner

Conversation

@minarc

@minarc minarc commented May 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The v0.12.3 short-poll loop tried to surface the welcome banner without the user re-invoking the slash command, but the UX gain wasn't worth the extra complexity (poll-state file, lifecycle bookkeeping). This PR reverts the short-poll feature and replaces it with a clearer three-step instruction in the expansion hook's RUN_INSTRUCTION so the user knows exactly what to do after device-flow auth completes:

  1. Paste the !-prefixed signin command
  2. Approve in the browser
  3. Re-run /skillmeter:signin to confirm and see the welcome banner

Changes

  • Delete skillmeter/scripts/lib/poll-state.js
  • Strip poll-state read/write helpers from credstore.js, signin.js, and the expansion hook
  • Rewrite RUN_INSTRUCTION in user_prompt_expansion_signin.js as a numbered three-step guide
  • Bump plugin.json 0.12.3 → 0.12.4

Test plan

  • Run /skillmeter:signout then /skillmeter:signin with no gh auth → expect Claude to relay the new three-step instruction
  • Paste the ! command, complete GitHub auth, re-run /skillmeter:signin → welcome banner renders
  • Confirm no references to poll-state.js remain in any script

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved license token retrieval performance through caching, reducing repeated disk access.
  • Documentation

    • Enhanced sign-in instructions with clearer, step-by-step guidance for GitHub authentication and activation.
  • Refactor

    • Streamlined the background sign-in authentication flow for improved user experience.

Review Change Stack

…nin (v0.12.4)

The v0.12.3 short-poll loop tried to surface the welcome banner without
the user re-invoking the slash command, but the UX gain wasn't worth the
extra complexity (poll-state file, lifecycle bookkeeping). Revert the
short-poll feature and replace it with a clearer three-step instruction
in the expansion hook's RUN_INSTRUCTION so the user knows exactly what to
do after device-flow auth completes:

  1. Paste the `!`-prefixed signin command
  2. Approve in the browser
  3. Re-run /skillmeter:signin to confirm and see the banner

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 16, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0465c47-665c-4ddb-8abe-ea9aa3cac501

📥 Commits

Reviewing files that changed from the base of the PR and between 317460a and 10a9cd5.

📒 Files selected for processing (5)
  • skillmeter/.claude-plugin/plugin.json
  • skillmeter/scripts/credstore.js
  • skillmeter/scripts/lib/poll-state.js
  • skillmeter/scripts/signin.js
  • skillmeter/scripts/user_prompt_expansion_signin.js

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

Background device-flow polling switches from sentinel-file-based lifecycle tracking (poll-state.js) to direct process.exit() control, and license token reads shift from disk to in-memory cache. User-facing sign-in instructions expand to include multi-step GitHub approval steps, and the polling wait-for-license logic is removed. Plugin version bumps to 0.12.4.

Changes

Sign-in polling and credential caching simplification

Layer / File(s) Summary
Credential store caching optimization
skillmeter/scripts/credstore.js
getLicenseToken() returns the JWT from the in-memory cached store instead of always re-reading from disk, removing the bypass of cache-freshness guarantees and making callers dependent on external cache invalidation for license updates.
Background poll process-exit model
skillmeter/scripts/signin.js
Background device-flow polling terminates with explicit process.exit(0) on success or discard and process.exit(1) on failure, replacing prior pollState.markPollStarted() and markPollEnded() lifecycle tracking.
Sign-in user flow and instructions
skillmeter/scripts/user_prompt_expansion_signin.js
Removes poll-state.js imports and conditional logic that polled for license arrival from a background process; expands the RUN_INSTRUCTION user-facing text to include verbatim command pasting and explicit re-run instructions after GitHub authentication succeeds.
Plugin manifest version
skillmeter/.claude-plugin/plugin.json
Plugin version field updated from 0.12.3 to 0.12.4.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • jhunlee-dev

Poem

A poll-state file once stood guard by the door,
But now we just exit—no sentinel chore! 🐰
Cache tokens in mem'ry, no disk reads today,
Cleaner sign-in flows in a simpler way. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/signin-short-poll-banner

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.20.0)

OpenGrep fatal error (exit code 2):
┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m
[00.24][ERROR]: Error: exception Glob.Lexer.Syntax_error("malformed glob pattern: missing ']'")
Raised at Glob__Lexer.syntax_error in file "libs/glob/Lexer.mll", line 8, characters 2-26
Called from Glob__Lexer.__ocaml_lex_token_rec in file "libs/glob/Lexer.mll", line 29, characters 26-53
Cal


Comment @coderabbitai help to get the list of available commands and usage tips.

@minarc
minarc merged commit 425c68a into main May 16, 2026
1 check was pending
@TheStarkor
TheStarkor deleted the feat/signin-short-poll-banner branch September 21, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant