Skip to content

💄(activate): show user code before url - #60

Merged
minarc merged 1 commit into
mainfrom
fix/activate-code-before-url
May 15, 2026
Merged

minarc merged 1 commit into
mainfrom
fix/activate-code-before-url

Conversation

@minarc

@minarc minarc commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Swap the device-flow steps in /skillmeter:activate so the user code is shown before the verification URL
  • Fold the "copied to your clipboard" hint into step 1 so it sits next to the code

Test plan

  • Run /skillmeter:activate on a machine without a cached license
  • Verify step 1 shows the code (with clipboard hint when applicable) and step 2 shows the URL to paste it into
  • Confirm background polling and re-run-to-confirm still work

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Improved device-flow authentication instructions with clearer step ordering and wording for better user experience.
    • Added explicit clipboard confirmation feedback when code is successfully copied during activation.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The device-authentication flow in skillmeter/scripts/activate.js now instructs users to copy the device code first, then open the browser and paste it. The prompt order and clipboard messaging are updated to match this revised workflow.

Changes

Device Login Flow Instructions

Layer / File(s) Summary
Device login step instructions
skillmeter/scripts/activate.js
Console prompts for GitHub device-flow authentication reorder instructions to guide users to copy the code first, then open the verification URI and paste it. Conditional clipboard confirmation message replaces the prior browser-first sequence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jhunlee-dev

Poem

🐇 A prompt so small, yet clear and bright,
Copy first, then paste just right,
Instructions dance in new array,
Users now will find their way! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: reordering the device-flow steps to show the user code before the URL, which matches the core objective of the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/activate-code-before-url

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.20.0)

OpenGrep fatal error (exit code 2):
┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m
[00.16][ERROR]: Error: exception Glob.Lexer.Syntax_error("malformed glob pattern: missing ']'")
Raised at Glob__Lexer.syntax_error in file "libs/glob/Lexer.mll", line 8, characters 2-26
Called from Glob__Lexer.__ocaml_lex_token_rec in file "libs/glob/Lexer.mll", line 29, characters 26-53
Cal

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@minarc
minarc merged commit 943b0e7 into main May 15, 2026
1 check was pending
@TheStarkor
TheStarkor deleted the fix/activate-code-before-url branch September 21, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant