Skip to content

feat(activate): auto-open browser on device flow; drop sk- skill prefix - #55

Merged
minarc merged 1 commit into
mainfrom
feat/high-value-hook-events
May 5, 2026
Merged

minarc merged 1 commit into
mainfrom
feat/high-value-hook-events

Conversation

@minarc

@minarc minarc commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • activate.js: open the GitHub verification URL in the system default browser (macOS open, Windows start, Linux xdg-open/wslview) and emit the URL/code on stdout so it stays visible when run via Claude Code's `!`-prefix runner (which buffers stderr).
  • Rename slash-command skill sk-telemetry → telemetry; update the SessionStart nudge and the AGENTS.md skills path glob.

Why

Running `! …/bin/activate` previously appeared to hang: no browser opened (the script never tried to) and the device-flow code was written to stderr, so users couldn't see what to do during the long polling loop.

Test plan

  • Run `! skillmeter/bin/activate` on macOS with no `gh` token — browser opens, code is shown on stdout, polling completes after approval.
  • Run `/skillmeter:telemetry status` and confirm the slash command resolves to the renamed skill.
  • On a fresh project, confirm SessionStart prints the new `/skillmeter:telemetry enable|disable` nudge.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated skill naming pattern guidelines in repository documentation.
  • Bug Fixes

    • Improved activation flow with formatted login prompts and automatic browser launching for device authentication.
  • Chores

    • Updated telemetry command naming in session startup guidance.

@minarc
minarc merged commit f17d05d into main May 5, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bb582b37-5d17-4d4c-9d8b-cbab6498d228

📥 Commits

Reviewing files that changed from the base of the PR and between 7d889b8 and 00c2df6.

📒 Files selected for processing (4)
  • AGENTS.md
  • skillmeter/scripts/activate.js
  • skillmeter/scripts/session_start.js
  • skillmeter/skills/telemetry/SKILL.md

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

Documentation path patterns for skill commands were updated from sk-* to *, and the activation script was refactored to route user-facing prompts to stdout via a new say() function with added cross-platform browser launching. Session-start telemetry guidance messages were updated to reference the new slash-command pattern.

Changes

Skill Activation & Command Naming Updates

Layer / File(s) Summary
Documentation
AGENTS.md
Documented path pattern for user-facing slash-command skills updated from skillmeter/skills/sk-* to skillmeter/skills/*.
UX & Output Refactoring
skillmeter/scripts/activate.js
Added say() function to write prompts to stdout; added openBrowser(url) helper for cross-platform browser launching; rewrote device-flow banner and approval flow to use say() instead of stderr-based log().
Command Reference Updates
skillmeter/scripts/session_start.js
Telemetry guidance updated to reference new /skillmeter:telemetry slash-command instead of /skillmeter:sk-telemetry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • jhunlee-dev

Poem

🐰 Hopping through skill paths sans the "sk-",
stdout now sings where stderr used to be,
Browser windows pop with gentle care,
Commands are clean, the UX is fair!
Telemetry guides point the way so bright. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/high-value-hook-events

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.20.0)

OpenGrep fatal error (exit code 2):
┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

�[1m Loading rules from local config...�[0m
[00.24][ERROR]: Error: exception Glob.Lexer.Syntax_error("malformed glob pattern: missing ']'")
Raised at Glob__Lexer.syntax_error in file "libs/glob/Lexer.mll", line 8, characters 2-26
Called from Glob__Lexer.__ocaml_lex_token_rec in file "libs/glob/Lexer.mll", line 29, characters 26-53
Cal


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant