Skip to content

dev - #5

Merged
minarc merged 3 commits into
mainfrom
dev
Mar 3, 2026
Merged

dev#5
minarc merged 3 commits into
mainfrom
dev

Conversation

@minarc

@minarc minarc commented Mar 3, 2026 •

Copy link
Copy Markdown
Contributor
  • ✨(logger): add tool_result to filtered content
  • ✨ implement salted hmac-sha256 hashing
  • ✨(skillmeter): implement keychain license token

Summary by CodeRabbit

  • New Features

    • Introduced license token-based authorization to replace API key authentication.
    • Added salted hashing functionality for improved privacy protection of file paths and transcripts.
  • Refactor

    • Updated authorization and hashing mechanisms across modules for enhanced security and privacy protection.

@minarc
minarc requested a review from jhunlee-dev March 3, 2026 08:13
@minarc
minarc merged commit 91b0b32 into main Mar 3, 2026
@coderabbitai

coderabbitai Bot commented Mar 3, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 55d66b6 and 48af25e.

📒 Files selected for processing (5)
  • skillmeter/scripts/logger.js
  • skillmeter/scripts/post_tool_use.js
  • skillmeter/scripts/transfer_conversation.js
  • skillmeter/scripts/transfer_event.js
  • skillmeter/scripts/user_prompt_submit.js

Walkthrough

The changes introduce per-user hash salt management via macOS Keychain with file-based fallback, implement HMAC-SHA256 hashing for improved privacy, add license token retrieval from Keychain, and replace API key authorization with token-based authentication across multiple scripts.

Changes

Cohort / File(s) Summary
Hash Salt & Licensing Infrastructure
skillmeter/scripts/logger.js
Introduced HASH_SALT_SERVICE and LICENSE_SERVICE constants; implemented getOrCreateHashSalt with Keychain + file fallback, getLicenseToken, and hashHmac for HMAC-SHA256 hashing; replaced hashSha256 with hashForFilename internally; expanded filterMessageContent to support tool_result type.
Privacy Hashing Updates
skillmeter/scripts/post_tool_use.js, skillmeter/scripts/user_prompt_submit.js
Replaced hashSha256 with hashHmac for file/transcript path privacy hashing; added getOrCreateHashSalt retrieval and salt-based HMAC computation; updated imports to reflect new hashing exports.
Token-Based Authorization
skillmeter/scripts/transfer_conversation.js, skillmeter/scripts/transfer_event.js
Replaced API key environment variable (SKILLMETER_API_KEY) with getLicenseToken for Authorization header; removed hardcoded/environment-based auth in favor of Keychain-managed license tokens.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Implement transcript file processing with byte offset #1: Directly intersects with logger.js hashing changes (hashHmac, HASH_SALT_SERVICE, hashForFilename) and updated usage in post_tool_use and user_prompt_submit, which depend on filename hashing and filterMessageContent expansions.

Poem

🐰 A hop through hashes, salts so fine,
Keychain keys in every line,
No more API keys in sight,
Tokens dance with crypto's might!
Security leaps, the code takes flight! 🔐✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant