Repository navigation
Plugin surface modernization: manifest metadata + skills/ migration - #43
Conversation
Plugin marketplace pages render these fields to help users decide whether to install. The description is adapted from the plugin's README. homepage points to the product landing page; repository to the monorepo housing all plugin sources. license field is intentionally omitted — no LICENSE file exists in the repo yet. Add the field once a license is chosen. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughPlugin manifest enhanced with new metadata fields ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skillmeter/scripts/activate.js`:
- Around line 30-33: The CLIENT_ID selection currently uses raw environment
values which may include whitespace; update the constant initialization for
CLIENT_ID so each candidate (process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID,
process.env.SKILLMETER_GITHUB_CLIENT_ID, and the literal default) is trimmed and
treated as empty if only whitespace before falling back — i.e., trim each env
value and only use it if trimmed.length > 0, otherwise continue to the next
candidate when setting CLIENT_ID in activate.js.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e4204b87-8101-442a-90b7-4a22e3e4ef07
📒 Files selected for processing (4)
skillmeter/.claude-plugin/plugin.jsonskillmeter/scripts/activate.jsskillmeter/skills/sk-activate/SKILL.mdskillmeter/skills/sk-telemetry/SKILL.md
💤 Files with no reviewable changes (2)
- skillmeter/skills/sk-activate/SKILL.md
- skillmeter/skills/sk-telemetry/SKILL.md
| const CLIENT_ID = | ||
| process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID || | ||
| process.env.SKILLMETER_GITHUB_CLIENT_ID || | ||
| "Ov23ct86rS80kpl7o2Xg"; |
There was a problem hiding this comment.
Normalize env-provided client IDs before selecting one.
If a user enters a value with leading/trailing whitespace (or whitespace-only), activation can fail with a hard-to-diagnose OAuth error. Trim candidates before fallback selection.
Suggested patch
-const CLIENT_ID =
- process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID ||
- process.env.SKILLMETER_GITHUB_CLIENT_ID ||
- "Ov23ct86rS80kpl7o2Xg";
+const DEFAULT_CLIENT_ID = "Ov23ct86rS80kpl7o2Xg";
+const normalize = (v) => (typeof v === "string" ? v.trim() : "");
+const CLIENT_ID =
+ normalize(process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID) ||
+ normalize(process.env.SKILLMETER_GITHUB_CLIENT_ID) ||
+ DEFAULT_CLIENT_ID;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const CLIENT_ID = | |
| process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID || | |
| process.env.SKILLMETER_GITHUB_CLIENT_ID || | |
| "Ov23ct86rS80kpl7o2Xg"; | |
| const DEFAULT_CLIENT_ID = "Ov23ct86rS80kpl7o2Xg"; | |
| const normalize = (v) => (typeof v === "string" ? v.trim() : ""); | |
| const CLIENT_ID = | |
| normalize(process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID) || | |
| normalize(process.env.SKILLMETER_GITHUB_CLIENT_ID) || | |
| DEFAULT_CLIENT_ID; |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@skillmeter/scripts/activate.js` around lines 30 - 33, The CLIENT_ID selection
currently uses raw environment values which may include whitespace; update the
constant initialization for CLIENT_ID so each candidate
(process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID,
process.env.SKILLMETER_GITHUB_CLIENT_ID, and the literal default) is trimmed and
treated as empty if only whitespace before falling back — i.e., trim each env
value and only use it if trimmed.length > 0, otherwise continue to the next
candidate when setting CLIENT_ID in activate.js.
Claude Code's plugin reference marks the flat `commands/` layout as
the legacy form and recommends `skills/<name>/SKILL.md` for new
plugins. The skill name is derived from the directory name, which
now matches the invocation ("/skillmeter:sk-activate", same as
before).
Two files migrated, content unchanged except for dropping the
redundant `name:` frontmatter field — the docs now say the directory
basename is the source of truth and the frontmatter name is a
fallback for edge cases (like the plugin root pointing at a single
SKILL.md).
commands/sk-activate.md → skills/sk-activate/SKILL.md
commands/sk-telemetry.md → skills/sk-telemetry/SKILL.md
The `commands/` directory is removed. No script or doc referenced
the old path by name, so nothing else needed touching.
Invocation paths for end users are unchanged:
/skillmeter:sk-activate
/skillmeter:sk-telemetry <enable|disable|status>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6b938e4 to
8a35267
Compare
Summary
Two docs-recommended improvements from the 2026-04 Claude Code plugin reference. Each is its own commit so it can be reverted in isolation.
description,homepage,repository. These render on the plugin marketplace page and help users decide whether to install.commands/→skills/(Implement transcript file processing with byte offset #1) — the docs call the flatcommands/form legacy and recommendskills/<name>/SKILL.md. Moves two skills; drops the redundantname:frontmatter because the directory basename is now the source of truth. Invocation paths are unchanged:/skillmeter:sk-activateand/skillmeter:sk-telemetrystill work identically.What's NOT in this PR (and why)
Originally this PR also included a
userConfig.github_client_identry to expose the GitHub OAuth client_id as a first-class config field. That commit was dropped: the SkillBench OAuth app is the only legitimate value, so exposing it as user-configurable would only let users break activation without any corresponding benefit. TheSKILLMETER_GITHUB_CLIENT_IDenv var fallback inactivate.jsis left intact for dev/testing.Files touched
skillmeter/.claude-plugin/plugin.json— adddescription,homepage,repositoryskillmeter/commands/sk-activate.md→skillmeter/skills/sk-activate/SKILL.md(rename)skillmeter/commands/sk-telemetry.md→skillmeter/skills/sk-telemetry/SKILL.md(rename)skillmeter/commands/— removedNot included (follow-ups)
licensefield in the manifest — no LICENSE file in the repo yet; add the field when a license is chosen.userConfig.telemetry_defaultto replace the macOS-only osascript opt-in dialog — cross-OS support is a bigger migration touching logger.js'spromptTelemetryOptIn, will handle in a dedicated PR.userConfig.tenant_subdomainoverride — depends on the broader refactor to move away from the hardcodedapi-meter-andela.skillbench.comemergency routing.userConfigtelemetry work lands so users get both in one update cycle.Verification
jq .on the manifest — valid JSON, all fields presentsk-activate,sk-telemetry) match the old skill names exactly, so/skillmeter:sk-*command names are byte-identical after the migrationcommands/by name (grep clean)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation