Skip to content

Plugin surface modernization: manifest metadata + skills/ migration - #43

Merged
minarc merged 2 commits into
mainfrom
feat/plugin-surface-modernization
Apr 22, 2026
Merged

minarc merged 2 commits into
mainfrom
feat/plugin-surface-modernization

Conversation

@minarc

@minarc minarc commented Apr 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two docs-recommended improvements from the 2026-04 Claude Code plugin reference. Each is its own commit so it can be reverted in isolation.

  1. Manifest metadata (dev #3) — add description, homepage, repository. These render on the plugin marketplace page and help users decide whether to install.
  2. commands/ → skills/ (Implement transcript file processing with byte offset #1) — the docs call the flat commands/ form legacy and recommend skills/<name>/SKILL.md. Moves two skills; drops the redundant name: frontmatter because the directory basename is now the source of truth. Invocation paths are unchanged: /skillmeter:sk-activate and /skillmeter:sk-telemetry still work identically.

What's NOT in this PR (and why)

Originally this PR also included a userConfig.github_client_id entry to expose the GitHub OAuth client_id as a first-class config field. That commit was dropped: the SkillBench OAuth app is the only legitimate value, so exposing it as user-configurable would only let users break activation without any corresponding benefit. The SKILLMETER_GITHUB_CLIENT_ID env var fallback in activate.js is left intact for dev/testing.

Files touched

  • skillmeter/.claude-plugin/plugin.json — add description, homepage, repository
  • skillmeter/commands/sk-activate.md → skillmeter/skills/sk-activate/SKILL.md (rename)
  • skillmeter/commands/sk-telemetry.md → skillmeter/skills/sk-telemetry/SKILL.md (rename)
  • skillmeter/commands/ — removed

Not included (follow-ups)

  • license field in the manifest — no LICENSE file in the repo yet; add the field when a license is chosen.
  • userConfig.telemetry_default to replace the macOS-only osascript opt-in dialog — cross-OS support is a bigger migration touching logger.js's promptTelemetryOptIn, will handle in a dedicated PR.
  • userConfig.tenant_subdomain override — depends on the broader refactor to move away from the hardcoded api-meter-andela.skillbench.com emergency routing.
  • Plugin version bump — hold until the follow-up userConfig telemetry work lands so users get both in one update cycle.

Verification

  • jq . on the manifest — valid JSON, all fields present
  • Invocation matrix — directory basenames (sk-activate, sk-telemetry) match the old skill names exactly, so /skillmeter:sk-* command names are byte-identical after the migration
  • No other file referenced commands/ by name (grep clean)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added user-configurable GitHub OAuth client ID option to customize authentication settings.
  • Documentation

    • Enhanced plugin manifest with description, homepage, and repository metadata.
    • Streamlined skill documentation by removing redundant metadata declarations.

Plugin marketplace pages render these fields to help users decide
whether to install. The description is adapted from the plugin's
README. homepage points to the product landing page; repository to
the monorepo housing all plugin sources.

license field is intentionally omitted — no LICENSE file exists in
the repo yet. Add the field once a license is chosen.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 22, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7765a245-9247-435e-a020-c65374cf6b48

📥 Commits

Reviewing files that changed from the base of the PR and between 6b938e4 and 8a35267.

📒 Files selected for processing (2)
  • skillmeter/skills/sk-activate/SKILL.md
  • skillmeter/skills/sk-telemetry/SKILL.md
💤 Files with no reviewable changes (2)
  • skillmeter/skills/sk-activate/SKILL.md
  • skillmeter/skills/sk-telemetry/SKILL.md

Walkthrough

Plugin manifest enhanced with new metadata fields (description, homepage, repository) and configurable OAuth settings via userConfig. Skill metadata frontmatter simplified by removing redundant name fields from two skill definitions.

Changes

Cohort / File(s) Summary
Plugin Configuration
skillmeter/.claude-plugin/plugin.json
Added descriptive metadata fields and introduced optional userConfig section with configurable github_client_id for GitHub OAuth client override in /sk-activate.
Skill Metadata
skillmeter/skills/sk-activate/SKILL.md, skillmeter/skills/sk-telemetry/SKILL.md
Removed redundant name frontmatter fields from skill manifests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • jhunlee-dev

Poem

🐰 Hops through configs with glee,
OAuth IDs now configurable, you see!
Names pruned clean from skill definitions bright,
Plugin manifest shines with metadata light! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the three main changes: manifest metadata updates, userConfig addition for GitHub client ID, and the commands/ to skills/ directory migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/plugin-surface-modernization

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skillmeter/scripts/activate.js`:
- Around line 30-33: The CLIENT_ID selection currently uses raw environment
values which may include whitespace; update the constant initialization for
CLIENT_ID so each candidate (process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID,
process.env.SKILLMETER_GITHUB_CLIENT_ID, and the literal default) is trimmed and
treated as empty if only whitespace before falling back — i.e., trim each env
value and only use it if trimmed.length > 0, otherwise continue to the next
candidate when setting CLIENT_ID in activate.js.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4204b87-8101-442a-90b7-4a22e3e4ef07

📥 Commits

Reviewing files that changed from the base of the PR and between a0038b5 and 6b938e4.

📒 Files selected for processing (4)
  • skillmeter/.claude-plugin/plugin.json
  • skillmeter/scripts/activate.js
  • skillmeter/skills/sk-activate/SKILL.md
  • skillmeter/skills/sk-telemetry/SKILL.md
💤 Files with no reviewable changes (2)
  • skillmeter/skills/sk-activate/SKILL.md
  • skillmeter/skills/sk-telemetry/SKILL.md

Comment thread skillmeter/scripts/activate.js Outdated
Comment on lines +30 to +33
const CLIENT_ID =
process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID ||
process.env.SKILLMETER_GITHUB_CLIENT_ID ||
"Ov23ct86rS80kpl7o2Xg";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Normalize env-provided client IDs before selecting one.

If a user enters a value with leading/trailing whitespace (or whitespace-only), activation can fail with a hard-to-diagnose OAuth error. Trim candidates before fallback selection.

Suggested patch
-const CLIENT_ID =
-  process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID ||
-  process.env.SKILLMETER_GITHUB_CLIENT_ID ||
-  "Ov23ct86rS80kpl7o2Xg";
+const DEFAULT_CLIENT_ID = "Ov23ct86rS80kpl7o2Xg";
+const normalize = (v) => (typeof v === "string" ? v.trim() : "");
+const CLIENT_ID =
+  normalize(process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID) ||
+  normalize(process.env.SKILLMETER_GITHUB_CLIENT_ID) ||
+  DEFAULT_CLIENT_ID;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const CLIENT_ID =
process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID ||
process.env.SKILLMETER_GITHUB_CLIENT_ID ||
"Ov23ct86rS80kpl7o2Xg";
const DEFAULT_CLIENT_ID = "Ov23ct86rS80kpl7o2Xg";
const normalize = (v) => (typeof v === "string" ? v.trim() : "");
const CLIENT_ID =
normalize(process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID) ||
normalize(process.env.SKILLMETER_GITHUB_CLIENT_ID) ||
DEFAULT_CLIENT_ID;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@skillmeter/scripts/activate.js` around lines 30 - 33, The CLIENT_ID selection
currently uses raw environment values which may include whitespace; update the
constant initialization for CLIENT_ID so each candidate
(process.env.CLAUDE_PLUGIN_OPTION_GITHUB_CLIENT_ID,
process.env.SKILLMETER_GITHUB_CLIENT_ID, and the literal default) is trimmed and
treated as empty if only whitespace before falling back — i.e., trim each env
value and only use it if trimmed.length > 0, otherwise continue to the next
candidate when setting CLIENT_ID in activate.js.

Claude Code's plugin reference marks the flat `commands/` layout as
the legacy form and recommends `skills/<name>/SKILL.md` for new
plugins. The skill name is derived from the directory name, which
now matches the invocation ("/skillmeter:sk-activate", same as
before).

Two files migrated, content unchanged except for dropping the
redundant `name:` frontmatter field — the docs now say the directory
basename is the source of truth and the frontmatter name is a
fallback for edge cases (like the plugin root pointing at a single
SKILL.md).

  commands/sk-activate.md   → skills/sk-activate/SKILL.md
  commands/sk-telemetry.md  → skills/sk-telemetry/SKILL.md

The `commands/` directory is removed. No script or doc referenced
the old path by name, so nothing else needed touching.

Invocation paths for end users are unchanged:
  /skillmeter:sk-activate
  /skillmeter:sk-telemetry <enable|disable|status>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@minarc
minarc force-pushed the feat/plugin-surface-modernization branch from 6b938e4 to 8a35267 Compare April 22, 2026 17:38
@minarc minarc changed the title Plugin surface modernization: manifest metadata, userConfig, skills/ migration Plugin surface modernization: manifest metadata + skills/ migration Apr 22, 2026
@minarc
minarc merged commit da3a263 into main Apr 22, 2026
1 check passed
@TheStarkor
TheStarkor deleted the feat/plugin-surface-modernization branch September 21, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant