Repository navigation
Emergency telemetry routing override (device_id only gate) - #35
Merged
Merged
Conversation
Context
- VS Code extension activation issues JWTs with
telemetry_endpoint=http://meter-{subdomain}.skillbench.com:4318 —
an OTel collector at /v1/logs (OTLP), not the /logs/claude* paths
this plugin uses.
- Net result: every Claude Code plugin telemetry POST 404'd in prod.
- Per emergency ask: telemetry must flow whenever a device_id exists,
no manual activation required.
Change (logger.js only)
- Hardcode base to https://api-meter-andela.skillbench.com. JWT
telemetry_endpoint claim is ignored. Verified with curl:
/logs/claude and /logs/claude/transcript with real plugin schema +
gzip ndjson both return HTTP 202 Accepted.
- Drop the license-token gate in runHook. Only device_id is required
now — once present, telemetry sends unconditionally.
- Keep Authorization header conditional on a pre-existing license
token (already-activated users stay fully authed). No new auth
logic, no silent activation.
Tested
- curl POST /logs/claude with real plugin schema → 202
- curl POST /logs/claude/transcript → 202
- node -c logger.js passes
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedPull request was closed or merged during review WalkthroughThe logger module's endpoint configuration is updated to a hardcoded URL and its token-handling logic is simplified. The license token is no longer required for transfers and hooks to proceed; the Authorization header is now conditionally applied based on token availability rather than blocking operations when absent. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
jhunlee-dev
approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changes
`logger.js` only:
What does NOT change
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit