Skip to content

Dev - #32

Merged
minarc merged 4 commits into
mainfrom
dev
Apr 13, 2026
Merged

Dev#32
minarc merged 4 commits into
mainfrom
dev

Conversation

@minarc

@minarc minarc commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added repo-scoped filtering to restrict telemetry to repositories from specified GitHub organizations via configuration.
    • Status command now displays repo-scope filtering state and allowed organizations.
  • Documentation

    • Added guide for configuring repo-scoped filtering with .claude/settings.local.json examples and default filtering behavior.

john-skillbench and others added 4 commits April 12, 2026 20:38
Ensure Stop and SessionEnd still rotate and transfer the shared event log when repo-scoped telemetry is disallowed, while keeping transcript uploads on the allowed path only.

Made-with: Cursor
Fixed 1 file(s) based on 2 unresolved review comments.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
@coderabbitai

coderabbitai Bot commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d62c90f-a749-4944-9e30-c381718c77e0

📥 Commits

Reviewing files that changed from the base of the PR and between 33e9439 and ce10b2f.

📒 Files selected for processing (5)
  • skillmeter/README.md
  • skillmeter/scripts/logger.js
  • skillmeter/scripts/session_end.js
  • skillmeter/scripts/stop.js
  • skillmeter/scripts/telemetry.js

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


Walkthrough

This pull request adds repository-scope filtering to SkillMeter telemetry. Documentation describes the feature through configuration options in .claude/settings.local.json. The logger module gains Git remote parsing, organization extraction, and scope validation logic. Hook integration points now invoke telemetry skipping when repositories fall outside the allowed GitHub organization allowlist. The telemetry status command displays filtering configuration.

Changes

Cohort / File(s) Summary
Documentation
skillmeter/README.md
Added "Repo-Scoped Filtering" section with configuration examples and default filtering behavior.
Core Logger Implementation
skillmeter/scripts/logger.js
Implemented repo-scope gating via Git remote parsing, GitHub org extraction, and scope decision logic. Added hashed repo metadata to event payloads. Changed transferEventLog to return Promise<void>. Exported flushEventLog, getRepoScopeSettings, getRepoScopeDecision. Added options.afterSkip callback to runHook.
Hook Integration
skillmeter/scripts/session_end.js, skillmeter/scripts/stop.js
Added afterSkip: flushEventLog to hook options, ensuring event log flush when hook execution is skipped due to repo-scope filtering.
Telemetry Status
skillmeter/scripts/telemetry.js
Extended status action to display repo-scope filtering state: enabled status, allowed GitHub organizations, and unapproved repo inclusion setting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

  • PR #31: Implements identical repo-scope filtering feature with matching changes across all modified files.
  • PR #10: Modifies the same logging and transfer stack (logger.js, session_end.js, stop.js) with overlapping scope.

Suggested reviewers

  • jhunlee-dev

Poem

Through git remotes and org arrays, 🐰
We filter telemetry's pathways,
Each repo scope with care reviewed,
Organization-bound and understood! 🎯

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants