Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 86.54% 86.55% +<.01%
==========================================
Files 788 788
Lines 34670 34671 +1
Branches 2589 2589
==========================================
+ Hits 30006 30009 +3
+ Misses 3875 3873 -2
Partials 789 789
Continue to review full report at Codecov.
|
Member
|
This is fine... what I should have done done in the original Pr |
Member
Author
|
Och we all missed it. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This fixes the allocations we discovered in #348
Turns out we were double cloning and not disposing of frames when initializing the
ImageFrameCollection.